From: Bjorn Helgaas <helgaas@kernel.org>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Pawel Baldysiak <pawel.baldysiak@intel.com>,
Sinan Kaya <okaya@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Keith Busch <kbusch@kernel.org>,
Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [RFC 2/9] PCI: pci-bridge-emul: Eliminate reserved member
Date: Sat, 28 Mar 2020 16:43:51 -0500 [thread overview]
Message-ID: <20200328214351.GA129854@google.com> (raw)
In-Reply-To: <1581120007-5280-3-git-send-email-jonathan.derrick@intel.com>
[+cc Thomas, Russell]
On Fri, Feb 07, 2020 at 05:00:00PM -0700, Jon Derrick wrote:
> Assume any bit not in the Read-Only, Read-Write, or Write-1-to-Clear
> behavior masks is a Reserved bit and should return 0 on reads.
This also seems like it makes sense on its own, especially if you can
include a spec citation.
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> ---
> drivers/pci/pci-bridge-emul.c | 28 +++++++++++-----------------
> 1 file changed, 11 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
> index d065c2a..e0567ca 100644
> --- a/drivers/pci/pci-bridge-emul.c
> +++ b/drivers/pci/pci-bridge-emul.c
> @@ -24,6 +24,15 @@
> #define PCI_CAP_PCIE_START PCI_BRIDGE_CONF_END
> #define PCI_CAP_PCIE_END (PCI_CAP_PCIE_START + PCI_EXP_SLTSTA2 + 2)
>
> +/**
> + * struct pci_bridge_reg_behavior - register bits behaviors
> + * @ro: Read-Only bits
> + * @rw: Read-Write bits
> + * @w1c: Write-1-to-Clear bits
> + *
> + * Reads and Writes will be filtered by specified behavior. All other bits not
> + * declared are assumed 'Reserved' and will return 0 on reads.
> + */
> struct pci_bridge_reg_behavior {
> /* Read-only bits */
> u32 ro;
> @@ -33,9 +42,6 @@ struct pci_bridge_reg_behavior {
>
> /* Write-1-to-clear bits */
> u32 w1c;
> -
> - /* Reserved bits (hardwired to 0) */
> - u32 rsvd;
> };
>
> static const struct pci_bridge_reg_behavior pci_regs_behavior[] = {
> @@ -49,7 +55,6 @@ struct pci_bridge_reg_behavior {
> PCI_COMMAND_FAST_BACK) |
> (PCI_STATUS_CAP_LIST | PCI_STATUS_66MHZ |
> PCI_STATUS_FAST_BACK | PCI_STATUS_DEVSEL_MASK) << 16),
> - .rsvd = GENMASK(15, 10) | ((BIT(6) | GENMASK(3, 0)) << 16),
> .w1c = (PCI_STATUS_PARITY |
> PCI_STATUS_SIG_TARGET_ABORT |
> PCI_STATUS_REC_TARGET_ABORT |
> @@ -106,8 +111,6 @@ struct pci_bridge_reg_behavior {
> PCI_STATUS_REC_MASTER_ABORT |
> PCI_STATUS_SIG_SYSTEM_ERROR |
> PCI_STATUS_DETECTED_PARITY) << 16,
> -
> - .rsvd = ((BIT(6) | GENMASK(4, 0)) << 16),
> },
>
> [PCI_MEMORY_BASE / 4] = {
> @@ -140,12 +143,10 @@ struct pci_bridge_reg_behavior {
>
> [PCI_CAPABILITY_LIST / 4] = {
> .ro = GENMASK(7, 0),
> - .rsvd = GENMASK(31, 8),
> },
>
> [PCI_ROM_ADDRESS1 / 4] = {
> .rw = GENMASK(31, 11) | BIT(0),
> - .rsvd = GENMASK(10, 1),
> },
>
> /*
> @@ -168,8 +169,6 @@ struct pci_bridge_reg_behavior {
> .ro = (GENMASK(15, 8) | ((PCI_BRIDGE_CTL_FAST_BACK) << 16)),
>
> .w1c = BIT(10) << 16,
> -
> - .rsvd = (GENMASK(15, 12) | BIT(4)) << 16,
> },
> };
>
> @@ -196,13 +195,11 @@ struct pci_bridge_reg_behavior {
> */
> .w1c = (BIT(6) | GENMASK(3, 0)) << 16,
> .ro = GENMASK(5, 4) << 16,
> - .rsvd = GENMASK(15, 7) << 16,
> },
>
> [PCI_EXP_LNKCAP / 4] = {
> /* All bits are RO, except bit 23 which is reserved */
> .ro = lower_32_bits(~BIT(23)),
> - .rsvd = BIT(23),
> },
>
> [PCI_EXP_LNKCTL / 4] = {
> @@ -216,7 +213,6 @@ struct pci_bridge_reg_behavior {
> .rw = GENMASK(15, 14) | GENMASK(11, 3) | GENMASK(1, 0),
> .ro = GENMASK(13, 0) << 16,
> .w1c = GENMASK(15, 14) << 16,
> - .rsvd = GENMASK(13, 12) | BIT(2),
> },
>
> [PCI_EXP_SLTCAP / 4] = {
> @@ -234,7 +230,6 @@ struct pci_bridge_reg_behavior {
> .rw = GENMASK(14, 0),
> .w1c = (BIT(8) | GENMASK(4, 0)) << 16,
> .ro = GENMASK(7, 5) << 16,
> - .rsvd = BIT(15) | (GENMASK(15, 9) << 16),
> },
>
> [PCI_EXP_RTCTL / 4] = {
> @@ -246,7 +241,6 @@ struct pci_bridge_reg_behavior {
> */
> .rw = GENMASK(4, 0),
> .ro = BIT(0) << 16,
> - .rsvd = GENMASK(15, 5) | (GENMASK(15, 1) << 16),
> },
>
> [PCI_EXP_RTSTA / 4] = {
> @@ -256,7 +250,6 @@ struct pci_bridge_reg_behavior {
> */
> .ro = BIT(17) | GENMASK(15, 0),
> .w1c = BIT(16),
> - .rsvd = GENMASK(31, 18),
> },
> };
>
> @@ -364,7 +357,8 @@ int pci_bridge_emul_conf_read(struct pci_bridge_emul *bridge, int where,
> * Make sure we never return any reserved bit with a value
> * different from 0.
> */
> - *value &= ~behavior[reg / 4].rsvd;
> + *value &= behavior[reg / 4].ro | behavior[reg / 4].rw |
> + behavior[reg / 4].w1c;
>
> if (size == 1)
> *value = (*value >> (8 * (where & 3))) & 0xff;
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2020-03-28 21:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 23:59 [RFC 0/9] PCIe Hotplug Slot Emulation driver Jon Derrick
2020-02-07 23:59 ` [RFC 1/9] PCI: pci-bridge-emul: Update PCIe register behaviors Jon Derrick
2020-02-08 9:55 ` Andy Shevchenko
2020-03-28 21:42 ` Bjorn Helgaas
2020-02-08 0:00 ` [RFC 2/9] PCI: pci-bridge-emul: Eliminate reserved member Jon Derrick
2020-03-28 21:43 ` Bjorn Helgaas [this message]
2020-02-08 0:00 ` [RFC 3/9] PCI: pci-bridge-emul: Provide a helper to set behavior Jon Derrick
2020-02-08 0:00 ` [RFC 4/9] PCI: pciehp: Indirect slot register operations Jon Derrick
2020-02-08 0:00 ` [RFC 5/9] PCI: Add pcie_port_slot_emulated stub Jon Derrick
2020-02-08 0:00 ` [RFC 6/9] PCI: pciehp: Expose the poll loop to other drivers Jon Derrick
2020-02-08 0:00 ` [RFC 7/9] PCI: Move pci_dev_str_match to search.c Jon Derrick
2020-02-08 0:00 ` [RFC 8/9] PCI: pciehp: Add hotplug slot emulation driver Jon Derrick
2020-02-08 0:00 ` [RFC 9/9] PCI: pciehp: Wire up pcie_port_emulate_slot and pciehp_emul Jon Derrick
2020-02-10 7:01 ` [RFC 0/9] PCIe Hotplug Slot Emulation driver Christoph Hellwig
2020-02-10 15:05 ` Derrick, Jonathan
2020-02-10 16:58 ` hch
2020-02-10 17:09 ` Derrick, Jonathan
2020-03-28 21:51 ` Bjorn Helgaas
2020-03-30 17:43 ` Derrick, Jonathan
2020-03-30 17:49 ` hch
2020-04-01 21:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328214351.GA129854@google.com \
--to=helgaas@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=hch@lst.de \
--cc=jonathan.derrick@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@kernel.org \
--cc=pawel.baldysiak@intel.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).