From: kbuild test robot <lkp@intel.com>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: kbuild-all@lists.01.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <helgaas@kernel.org>
Subject: [pci:pci/edr 4/10] drivers/pci/pcie/err.c:168:28: error: 'service' undeclared; did you mean 'device'?
Date: Sun, 29 Mar 2020 02:21:20 +0800 [thread overview]
Message-ID: <202003290207.08KEL8mY%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3601 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/edr
head: 3a4c9f97543f0dbf580dd3646164e829ba08e600
commit: d9dbf5828770b236fcae3cc866d844fe360174d0 [4/10] PCI/ERR: Remove service dependency in pcie_do_recovery()
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
git checkout d9dbf5828770b236fcae3cc866d844fe360174d0
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/pci/pcie/err.c: In function 'pcie_do_recovery':
>> drivers/pci/pcie/err.c:168:28: error: 'service' undeclared (first use in this function); did you mean 'device'?
status = reset_link(dev, service);
^~~~~~~
device
drivers/pci/pcie/err.c:168:28: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/pci/pcie/err.c:168:12: error: too many arguments to function 'reset_link'
status = reset_link(dev, service);
^~~~~~~~~~
vim +168 drivers/pci/pcie/err.c
2e28bc84cf6eecd Oza Pawandeep 2018-05-17 148
d9dbf5828770b23 Kuppuswamy Sathyanarayanan 2020-03-23 149 void pcie_do_recovery(struct pci_dev *dev,
d9dbf5828770b23 Kuppuswamy Sathyanarayanan 2020-03-23 150 enum pci_channel_state state,
d9dbf5828770b23 Kuppuswamy Sathyanarayanan 2020-03-23 151 pci_ers_result_t (*reset_link)(struct pci_dev *pdev))
2e28bc84cf6eecd Oza Pawandeep 2018-05-17 152 {
542aeb9c8f930e4 Keith Busch 2018-09-20 153 pci_ers_result_t status = PCI_ERS_RESULT_CAN_RECOVER;
542aeb9c8f930e4 Keith Busch 2018-09-20 154 struct pci_bus *bus;
2e28bc84cf6eecd Oza Pawandeep 2018-05-17 155
bfcb79fca19d267 Keith Busch 2018-09-20 156 /*
bfcb79fca19d267 Keith Busch 2018-09-20 157 * Error recovery runs on all subordinates of the first downstream port.
bfcb79fca19d267 Keith Busch 2018-09-20 158 * If the downstream port detected the error, it is cleared at the end.
bfcb79fca19d267 Keith Busch 2018-09-20 159 */
bfcb79fca19d267 Keith Busch 2018-09-20 160 if (!(pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT ||
bfcb79fca19d267 Keith Busch 2018-09-20 161 pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM))
bfcb79fca19d267 Keith Busch 2018-09-20 162 dev = dev->bus->self;
542aeb9c8f930e4 Keith Busch 2018-09-20 163 bus = dev->subordinate;
bfcb79fca19d267 Keith Busch 2018-09-20 164
542aeb9c8f930e4 Keith Busch 2018-09-20 165 pci_dbg(dev, "broadcast error_detected message\n");
b5dfbeacf74865a Kuppuswamy Sathyanarayanan 2020-03-27 166 if (state == pci_channel_io_frozen) {
542aeb9c8f930e4 Keith Busch 2018-09-20 167 pci_walk_bus(bus, report_frozen_detected, &status);
6d2c89441571ea5 Kuppuswamy Sathyanarayanan 2020-03-23 @168 status = reset_link(dev, service);
:::::: The code at line 168 was first introduced by commit
:::::: 6d2c89441571ea534d6240f7724f518936c44f8d PCI/ERR: Update error status after reset_link()
:::::: TO: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
:::::: CC: Bjorn Helgaas <bhelgaas@google.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29018 bytes --]
reply other threads:[~2020-03-28 18:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003290207.08KEL8mY%lkp@intel.com \
--to=lkp@intel.com \
--cc=helgaas@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).