From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF743C2D0F1 for ; Tue, 31 Mar 2020 15:26:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B46BA20848 for ; Tue, 31 Mar 2020 15:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585668374; bh=5IJuX6AkKeckjXGkAnpY4cbNqHBPFLgHVhnLoOaMTdI=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=N7YfFsYcCV4ZjfWwO2pmBxAThEiu88p7ui3dLpniUG8ryWuXtn9i3m+bbDvURooEG jVBJiZyb/pph8PkttP09ysPqPx1orUxocFxtUYq7Z+fl2iK2UJSiWlh8pTMVCiigRm HbD7PrLYEOGnruKRwuAYp+vlK87W7VaR4Go9keJE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730464AbgCaP0K (ORCPT ); Tue, 31 Mar 2020 11:26:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:39840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730149AbgCaP0K (ORCPT ); Tue, 31 Mar 2020 11:26:10 -0400 Received: from localhost (mobile-166-175-186-165.mycingular.net [166.175.186.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9CF4620786; Tue, 31 Mar 2020 15:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585668369; bh=5IJuX6AkKeckjXGkAnpY4cbNqHBPFLgHVhnLoOaMTdI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=S/oqF+T/HoROYfLFrY1ioWZF2kvgn+TqZ1BT4qOw6L5CrOyrHgE3MbMhmE8CGoJO5 YdrpvTO4rp0NRKQr6DqkamIxS0DWA1Byijc8wOr2ELiD+yVjDYg49zvbg7lYW3qkSa EaYSi5CK3cgeHod56nIIqFUezoWvFggl0C/lpW1A= Date: Tue, 31 Mar 2020 10:25:54 -0500 From: Bjorn Helgaas To: Lorenzo Pieralisi Cc: bjorn@helgaas.com, Vidya Sagar , robh+dt@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, Andrew Murray , kishon@ti.com, gustavo.pimentel@synopsys.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, LKML , ARM , kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com Subject: Re: [PATCH V5 5/5] PCI: tegra: Add support for PCIe endpoint mode in Tegra194 Message-ID: <20200331152554.GA188434@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331082325.GA32028@e121166-lin.cambridge.arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Mar 31, 2020 at 09:23:25AM +0100, Lorenzo Pieralisi wrote: > On Mon, Mar 30, 2020 at 10:00:57PM -0500, Bjorn Helgaas wrote: > > On Mon, Mar 30, 2020 at 9:55 PM Vidya Sagar wrote: > > > On 3/31/2020 3:17 AM, Bjorn Helgaas wrote: > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > On Tue, Mar 03, 2020 at 11:40:52PM +0530, Vidya Sagar wrote: > > > >> Add support for the endpoint mode of Synopsys DesignWare core based > > > >> dual mode PCIe controllers present in Tegra194 SoC. > > > >> > > > >> Signed-off-by: Vidya Sagar > > > >> Acked-by: Thierry Reding > > > >> --- > > > >> V5: > > > >> * Added Acked-by: Thierry Reding > > > >> * Removed unwanted header file inclusion > > > >> > > > >> V4: > > > >> * Addressed Lorenzo's review comments > > > >> * Started using threaded irqs instead of kthreads > > > >> > > > >> V3: > > > >> * Addressed Thierry's review comments > > > >> > > > >> V2: > > > >> * Addressed Bjorn's review comments > > > >> * Made changes as part of addressing review comments for other patches > > > >> > > > >> drivers/pci/controller/dwc/Kconfig | 30 +- > > > >> drivers/pci/controller/dwc/pcie-tegra194.c | 679 ++++++++++++++++++++- > > > >> 2 files changed, 691 insertions(+), 18 deletions(-) > > > >> > > > >> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > > > >> index 0830dfcfa43a..169cde58dd92 100644 > > > >> --- a/drivers/pci/controller/dwc/Kconfig > > > >> +++ b/drivers/pci/controller/dwc/Kconfig > > > >> @@ -248,14 +248,38 @@ config PCI_MESON > > > >> implement the driver. > > > >> > > > >> config PCIE_TEGRA194 > > > >> - tristate "NVIDIA Tegra194 (and later) PCIe controller" > > > >> + tristate > > > >> + > > > >> +config PCIE_TEGRA194_HOST > > > >> + tristate "NVIDIA Tegra194 (and later) PCIe controller - Host Mode" > > > >> depends on ARCH_TEGRA_194_SOC || COMPILE_TEST > > > >> depends on PCI_MSI_IRQ_DOMAIN > > > >> select PCIE_DW_HOST > > > >> select PHY_TEGRA194_P2U > > > >> + select PCIE_TEGRA194 > > > >> + default y > > > > > > > > Sorry I missed this before, but why is this "default y"? From > > > > Documentation/kbuild/kconfig-language.rst: > > > > > > > > The default value deliberately defaults to 'n' in order to avoid > > > > bloating the build. With few exceptions, new config options should > > > > not change this. The intent is for "make oldconfig" to add as little > > > > as possible to the config from release to release. > > > > > > > > I do see that several other things in other drivers/pci/ Kconfig files > > > > are also "default y", and we should probably change some of them. But > > > > I don't want to add even more unless there's a good reason. > > > > > > > > I'm not looking for more reactions like these: > > > > > > > > https://lore.kernel.org/r/CAHk-=wiZ24JuVehJ5sEC0UG1Gk2nvB363wO02RRsR1oEht6R9Q@mail.gmail.com > > > > https://lore.kernel.org/r/CA+55aFzPpuHU1Nqd595SEQS=F+kXMzPs0Rba9FUgTodGxmXsgg@mail.gmail.com > > > > > > > > Can you please update this patch to either remove the "default y" or > > > > add the rationale for keeping it? > > > I'm fine with removing 'default y' line. > > > Should I send a patch only with this change? > > > > I think it's probably just as easy for Lorenzo to delete that line on > > his branch. If not, I'll cherry-pick the patches on that branch and > > do it locally. > > Done, pushed out. It is a guideline that it is worth keeping in mind > while I review the code, sorry for missing it. Got it, thanks! No worries, easy to fix. Bjorn