From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA98C2BA2B for ; Sun, 12 Apr 2020 07:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13104206E9 for ; Sun, 12 Apr 2020 07:35:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="PQNuB55F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725832AbgDLHfl (ORCPT ); Sun, 12 Apr 2020 03:35:41 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:52234 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbgDLHfl (ORCPT ); Sun, 12 Apr 2020 03:35:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ScwCZOvLyFziUiTE/s7lRo5HTwcGZHzgW4gqUCQQOG8=; b=PQNuB55FuOufIMCAs4l9mm4Pvl S39LPeZmPYgk9QUS9N6fe86vpkL6cVTqOlL0YxrW5Y6YqG9ZBnRxdkUpfXHRIRKbaEKPgaa+gU+FW oQgOHguDt5aMYpvsNP2RAOU9Y7E5r0LTejc6Lr1yoQm4Jf+LUvuW3Gyb1SI4Yseu6nD3b7X2NOmUt 41uMp06oHzCWbd0XYIFVP6aW32sl7LbpnWIY+4pFVlWgkyqfTbCey1pSGbaojkiKC/ymwtFINeJdS xw1lDAKFFi8fT5n2NdiMIVLHsvfwxk9HyA14BDDB43+6SreqF8mTPnYM3gk1nV5D/Dee3YeS3Y9hC Ykeaoddw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNX9N-0000Km-Ah; Sun, 12 Apr 2020 07:35:29 +0000 Date: Sun, 12 Apr 2020 00:35:29 -0700 From: Christoph Hellwig To: Daniel Drake Cc: Jon Derrick , Joerg Roedel , iommu@lists.linux-foundation.org, Bjorn Helgaas , Linux PCI , Lu Baolu , Linux Upstreaming Team Subject: Re: [PATCH 1/1] iommu/vt-d: use DMA domain for real DMA devices and subdevices Message-ID: <20200412073529.GA13784@infradead.org> References: <20200409191736.6233-1-jonathan.derrick@intel.com> <20200409191736.6233-2-jonathan.derrick@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sun, Apr 12, 2020 at 11:50:09AM +0800, Daniel Drake wrote: > > different addressing capabilities and some require translation. Instead we can > > put the real DMA dev and any subdevices on the DMA domain. This change assigns > > subdevices to the DMA domain, and moves the real DMA device to the DMA domain > > if necessary. > > Have you tested this with the real DMA device in identity mode? > It is not quite working for me. (Again, I'm not using VMD here, but > have looked closely and believe we're working under the same > constraints) So if you are not using VMD how does this matter for upstream?