From: Marek Behun <marek.behun@nic.cz> To: "Pali Rohár" <pali@kernel.org> Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@bootlin.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Rob Herring <robh+dt@kernel.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Andrew Murray <amurray@thegoodpenguin.co.uk>, Bjorn Helgaas <bhelgaas@google.com>, Remi Pommarel <repk@triplefau.lt>, Tomasz Maciej Nowak <tmn505@gmail.com>, Xogium <contact@xogium.me>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/8] PCI: aardvark: Fix support for Turris MOX and Compex wifi cards Date: Sun, 19 Apr 2020 06:01:05 +0200 [thread overview] Message-ID: <20200419060105.4c7bc4a5@nic.cz> (raw) In-Reply-To: <20200415160054.951-1-pali@kernel.org> Pali, I tested this series with Compex WLE900VX and with a ASMedia SATA card. Both are visible with these patches. But if I enable the pci-driver in U-Boot, kernel reports "link never came up" fo the WLE900VX card. The SATA card works in this case. advk-pcie d0070000.pcie: issuing PERST via reset GPIO for 1ms advk-pcie d0070000.pcie: setup link speed to 2 advk-pcie d0070000.pcie: link never came up advk-pcie d0070000.pcie: setup link speed to 1 advk-pcie d0070000.pcie: link never came up We should try to somehow reset the whole PCIe controller in Linux. There are the PCIe Core Warm Reset and PCIe PHY Warm Reset register. I also think that maybe we should try to reset the whole PCI comphy. Marek
prev parent reply other threads:[~2020-04-19 4:01 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-15 16:00 Pali Rohár 2020-04-15 16:00 ` [PATCH 1/8] PCI: aardvark: Set controller speed from Device Tree max-link-speed Pali Rohár 2020-04-15 16:00 ` [PATCH 2/8] dts: espressobin: Define max-link-speed for pcie0 Pali Rohár 2020-04-19 3:19 ` Marek Behun 2020-04-15 16:00 ` [PATCH 3/8] PCI: aardvark: Start link training immediately after enabling link training Pali Rohár 2020-04-15 16:00 ` [PATCH 4/8] PCI: aardvark: Do not overwrite Link Status register and ASPM Control bits in Link Control register Pali Rohár 2020-04-15 16:03 ` [PATCH 5/8] PCI: aardvark: Set final controller speed based on negotiated link speed Pali Rohár 2020-04-19 3:17 ` Marek Behun 2020-04-15 16:03 ` [PATCH 6/8] PCI: aardvark: Add support for issuing PERST via GPIO Pali Rohár 2020-04-19 3:23 ` Marek Behun 2020-04-15 16:03 ` [PATCH 7/8] dts: aardvark: Route pcie reset pin to gpio function and define reset-gpios for pcie Pali Rohár 2020-04-19 3:54 ` Marek Behun 2020-04-15 16:03 ` [PATCH 8/8] PCI: aardvark: Add FIXME for code which access PCIE_CORE_CMD_STATUS_REG Pali Rohár 2020-04-15 16:18 ` Pali Rohár 2020-04-16 15:50 ` [PATCH 0/8] PCI: aardvark: Fix support for Turris MOX and Compex wifi cards Tomasz Maciej Nowak 2020-04-19 4:01 ` Marek Behun [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200419060105.4c7bc4a5@nic.cz \ --to=marek.behun@nic.cz \ --cc=amurray@thegoodpenguin.co.uk \ --cc=andrew@lunn.ch \ --cc=bhelgaas@google.com \ --cc=contact@xogium.me \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=jason@lakedaemon.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=pali@kernel.org \ --cc=repk@triplefau.lt \ --cc=robh+dt@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=thomas.petazzoni@bootlin.com \ --cc=tmn505@gmail.com \ --subject='Re: [PATCH 0/8] PCI: aardvark: Fix support for Turris MOX and Compex wifi cards' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).