linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: pciehp: remove unused EMI() macro
@ 2020-04-20 12:51 Ani Sinha
  2020-04-20 13:22 ` Mika Westerberg
  2020-04-20 17:57 ` Bjorn Helgaas
  0 siblings, 2 replies; 4+ messages in thread
From: Ani Sinha @ 2020-04-20 12:51 UTC (permalink / raw)
  To: linux-kernel
  Cc: ani, Ani Sinha, Bjorn Helgaas, Andy Shevchenko, Keith Busch,
	Frederick Lawler, Denis Efremov, Mika Westerberg, Lukas Wunner,
	linux-pci

EMI() macro seems to be unused. So removing it. Thanks
Mika Westerberg <mika.westerberg@linux.intel.com> for
pointing it out.

Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
 drivers/pci/hotplug/pciehp.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
index 5747967..4fd200d 100644
--- a/drivers/pci/hotplug/pciehp.h
+++ b/drivers/pci/hotplug/pciehp.h
@@ -148,7 +148,6 @@ struct controller {
 #define MRL_SENS(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
 #define ATTN_LED(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
 #define PWR_LED(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
-#define EMI(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)
 #define NO_CMD_CMPL(ctrl)	((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS)
 #define PSN(ctrl)		(((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: pciehp: remove unused EMI() macro
  2020-04-20 12:51 [PATCH] PCI: pciehp: remove unused EMI() macro Ani Sinha
@ 2020-04-20 13:22 ` Mika Westerberg
  2020-04-20 17:57 ` Bjorn Helgaas
  1 sibling, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2020-04-20 13:22 UTC (permalink / raw)
  To: Ani Sinha
  Cc: linux-kernel, ani, Bjorn Helgaas, Andy Shevchenko,
	Frederick Lawler, Denis Efremov, Lukas Wunner, linux-pci

On Mon, Apr 20, 2020 at 06:21:41PM +0530, Ani Sinha wrote:
> EMI() macro seems to be unused. So removing it. Thanks
> Mika Westerberg <mika.westerberg@linux.intel.com> for
> pointing it out.
> 
> Signed-off-by: Ani Sinha <ani@anisinha.ca>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: pciehp: remove unused EMI() macro
  2020-04-20 12:51 [PATCH] PCI: pciehp: remove unused EMI() macro Ani Sinha
  2020-04-20 13:22 ` Mika Westerberg
@ 2020-04-20 17:57 ` Bjorn Helgaas
  2020-04-23 18:01   ` Ani Sinha
  1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2020-04-20 17:57 UTC (permalink / raw)
  To: Ani Sinha
  Cc: linux-kernel, ani, Andy Shevchenko, Keith Busch,
	Frederick Lawler, Denis Efremov, Mika Westerberg, Lukas Wunner,
	linux-pci

Hi Ani,

On Mon, Apr 20, 2020 at 06:21:41PM +0530, Ani Sinha wrote:
> EMI() macro seems to be unused. So removing it. Thanks
> Mika Westerberg <mika.westerberg@linux.intel.com> for
> pointing it out.
> 
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> ---
>  drivers/pci/hotplug/pciehp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> index 5747967..4fd200d 100644
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -148,7 +148,6 @@ struct controller {
>  #define MRL_SENS(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
>  #define ATTN_LED(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
>  #define PWR_LED(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
> -#define EMI(ctrl)		((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)

Thanks for the patch!  Can you squash it together with the HP_SUPR_RM
removal (and also check for any other unused ones at the same time)?
For trivial things like this, I'd rather merge one patch that removes
several unused things at once instead of several patches.

I like the subject of this one ("Removed unused ..."), but please
capitalize it as you did for the HP_SUPR_RM one so it matches previous
history.

Bjorn

>  #define NO_CMD_CMPL(ctrl)	((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS)
>  #define PSN(ctrl)		(((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)
>  
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: pciehp: remove unused EMI() macro
  2020-04-20 17:57 ` Bjorn Helgaas
@ 2020-04-23 18:01   ` Ani Sinha
  0 siblings, 0 replies; 4+ messages in thread
From: Ani Sinha @ 2020-04-23 18:01 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: linux-kernel, Ani Sinha, Andy Shevchenko, Keith Busch,
	Frederick Lawler, Denis Efremov, Mika Westerberg, Lukas Wunner,
	linux-pci

On Mon, Apr 20, 2020 at 11:27 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> Hi Ani,
>
> On Mon, Apr 20, 2020 at 06:21:41PM +0530, Ani Sinha wrote:
> > EMI() macro seems to be unused. So removing it. Thanks
> > Mika Westerberg <mika.westerberg@linux.intel.com> for
> > pointing it out.
> >
> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> > ---
> >  drivers/pci/hotplug/pciehp.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> > index 5747967..4fd200d 100644
> > --- a/drivers/pci/hotplug/pciehp.h
> > +++ b/drivers/pci/hotplug/pciehp.h
> > @@ -148,7 +148,6 @@ struct controller {
> >  #define MRL_SENS(ctrl)               ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
> >  #define ATTN_LED(ctrl)               ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
> >  #define PWR_LED(ctrl)                ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
> > -#define EMI(ctrl)            ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)
>
> Thanks for the patch!  Can you squash it together with the HP_SUPR_RM
> removal (and also check for any other unused ones at the same time)?
> For trivial things like this, I'd rather merge one patch that removes
> several unused things at once instead of several patches.
>
> I like the subject of this one ("Removed unused ..."), but please
> capitalize it as you did for the HP_SUPR_RM one so it matches previous
> history.

I have sent an updated patch few days back.

ani

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-23 18:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 12:51 [PATCH] PCI: pciehp: remove unused EMI() macro Ani Sinha
2020-04-20 13:22 ` Mika Westerberg
2020-04-20 17:57 ` Bjorn Helgaas
2020-04-23 18:01   ` Ani Sinha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).