From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 179ABC3815B for ; Mon, 20 Apr 2020 17:57:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF27820CC7 for ; Mon, 20 Apr 2020 17:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587405457; bh=1QfeIdYAdaoPYZPVIY/AQvVUA98AZnRFonLWpP+zWZ8=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=f0ySpgxVhKsNyGBs9cCKau52FBO6gwj4AQ+GBzNgbXyqedShOS8mNys25uGHj6Ocz Z2uoe84u0lMYh0hrKhTGC9Wsj8A1ielwYJw+J7Mc3QpBUr1wtmTxipEe7C9aj76Nu8 c8atcuITYQv4pqld19RT11uZimlJimlnZ7cMMqe0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725784AbgDTR5h (ORCPT ); Mon, 20 Apr 2020 13:57:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:34548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbgDTR5h (ORCPT ); Mon, 20 Apr 2020 13:57:37 -0400 Received: from localhost (mobile-166-175-186-98.mycingular.net [166.175.186.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E8E520B1F; Mon, 20 Apr 2020 17:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587405456; bh=1QfeIdYAdaoPYZPVIY/AQvVUA98AZnRFonLWpP+zWZ8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=isVsuct1teVVrXGWhe+smoFYkCAXLHWLHhmKq/KoBg4bf+k2drAK+0l5uReYejijn nvYkJdhR17R072goe6KIZH1F/jL2+a6tlZnk3piC/Xbq8JCFRwn09DWzJeQi2lyN9E UotslwHOshcxVcY+mmLz9luaeplq+d51jUDdJKOo= Date: Mon, 20 Apr 2020 12:57:34 -0500 From: Bjorn Helgaas To: Ani Sinha Cc: linux-kernel@vger.kernel.org, ani@anirban.org, Andy Shevchenko , Keith Busch , Frederick Lawler , Denis Efremov , Mika Westerberg , Lukas Wunner , linux-pci@vger.kernel.org Subject: Re: [PATCH] PCI: pciehp: remove unused EMI() macro Message-ID: <20200420175734.GA53587@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587387114-38475-1-git-send-email-ani@anisinha.ca> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Ani, On Mon, Apr 20, 2020 at 06:21:41PM +0530, Ani Sinha wrote: > EMI() macro seems to be unused. So removing it. Thanks > Mika Westerberg for > pointing it out. > > Signed-off-by: Ani Sinha > --- > drivers/pci/hotplug/pciehp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h > index 5747967..4fd200d 100644 > --- a/drivers/pci/hotplug/pciehp.h > +++ b/drivers/pci/hotplug/pciehp.h > @@ -148,7 +148,6 @@ struct controller { > #define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP) > #define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP) > #define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP) > -#define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP) Thanks for the patch! Can you squash it together with the HP_SUPR_RM removal (and also check for any other unused ones at the same time)? For trivial things like this, I'd rather merge one patch that removes several unused things at once instead of several patches. I like the subject of this one ("Removed unused ..."), but please capitalize it as you did for the HP_SUPR_RM one so it matches previous history. Bjorn > #define NO_CMD_CMPL(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS) > #define PSN(ctrl) (((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19) > > -- > 2.7.4 >