From: Bjorn Helgaas <helgaas@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>,
alsa-devel@alsa-project.org, Roy Spliet <nouveau@spliet.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org
Subject: Re: Unrecoverable AER error when resuming from RAM (hda regression in 5.7-rc2)
Date: Wed, 22 Apr 2020 18:21:27 -0500 [thread overview]
Message-ID: <20200422232127.GA24666@google.com> (raw)
In-Reply-To: <s5h8sinxlfz.wl-tiwai@suse.de>
On Wed, Apr 22, 2020 at 11:25:04PM +0200, Takashi Iwai wrote:
> On Wed, 22 Apr 2020 22:50:28 +0200,
> Bjorn Helgaas wrote:
> > ...
> > I feel like this UR issue could be a PCI core issue or maybe some sort
> > of misuse of PCI power management, but I can't seem to get traction on
> > it.
> >
> > > Then the display freezes and the system basically falls apart (can't
> > > even sudo reboot -f, need to use magic sysrq).
> > >
> > > I bisected this to "ALSA: hda: Skip controller resume if not needed".
> > > Setting snd_hda_intel.power_save=0 resolves the issue.
> >
> > FWIW, the complete citation is c4c8dd6ef807 ("ALSA: hda: Skip
> > controller resume if not needed"),
> > https://git.kernel.org/linus/c4c8dd6ef807, which first appeared in
> > v5.7-rc2.
>
> Yes, and I posted the fix patch right now:
> https://lore.kernel.org/r/20200422203744.26299-1-tiwai@suse.de
>
> The possible cause was the tricky resume code that both HD-audio
> controller (the parent PCI device) and the codec devices used.
>
> At least the patch above seems working for the reporter's machine.
> Now we need a bit more testing before merging, but it looks promising,
> so far.
Great, I'm glad you figured something out because I sure wasn't
getting anywhere!
Maybe this is a tangent, but I can't figure out what
snd_power_change_state() is doing. It *looks* like it's supposed to
change the PCI power state, but I gave up trying to figure out where
it actually touches the device.
It seems like sound has more magic in power management than other
device types, which makes me wonder if we're not providing the right
interfaces or something.
Bjorn
next prev parent reply other threads:[~2020-04-22 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1587494585.7pihgq0z3i.none.ref@localhost>
2020-04-21 19:08 ` Unrecoverable AER error when resuming from RAM (hda regression in 5.7-rc2) Alex Xu (Hello71)
2020-04-21 19:40 ` Takashi Iwai
2020-04-22 20:50 ` Bjorn Helgaas
2020-04-22 21:25 ` Takashi Iwai
2020-04-22 23:21 ` Bjorn Helgaas [this message]
2020-04-23 7:05 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422232127.GA24666@google.com \
--to=helgaas@kernel.org \
--cc=alex_y_xu@yahoo.ca \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nouveau@spliet.org \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).