From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A94C54FD0 for ; Fri, 24 Apr 2020 23:36:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD39E214AF for ; Fri, 24 Apr 2020 23:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587771401; bh=GahPYb5c20kvompQ2WK3WeCxh8bcOl0V6Hz+kuMMs9g=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=yb7EKSkWSzJRI2YYsINRB6v7AfneUjTc83++ugiMevd4y8xGXM8JKO5iSlAazJA// J3m3xU6Ej9yAUY/b8rPIbX7B+CgodKaqwTxFX0zoqU36Qhqep4Q87n1757LKX1X7Mr xnurv6cWU0E2Tq+7vu4zzLygGBc/MFIyJSGW6dK4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725932AbgDXXgl (ORCPT ); Fri, 24 Apr 2020 19:36:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:46732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgDXXgl (ORCPT ); Fri, 24 Apr 2020 19:36:41 -0400 Received: from localhost (mobile-166-175-187-210.mycingular.net [166.175.187.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58994221F6; Fri, 24 Apr 2020 23:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587771400; bh=GahPYb5c20kvompQ2WK3WeCxh8bcOl0V6Hz+kuMMs9g=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=aqUBPJWqvjY2FOGu2DMxYlhFiTZVjS/DBIvVPh2jxsSIImJBsL9z2ZraVYnUr88SE gp4mutSkGBRFcEQOhmOIXupbiTyHnAJPVfVMMuRoCwDm6McmRL611eE4Y5o0etxVh7 QByIlspt0Yr7us9nkJxU6glsgDdW1GFpIfh3S0H0= Date: Fri, 24 Apr 2020 18:36:38 -0500 From: Bjorn Helgaas To: sathyanarayanan.kuppuswamy@linux.intel.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com Subject: Re: [PATCH v1 1/1] PCI/EDR: Change ACPI event message log level Message-ID: <20200424233638.GA220955@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01afb4e01efbe455de0c445bef6cf3ffc59340d2.1586996350.git.sathyanarayanan.kuppuswamy@linux.intel.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Apr 15, 2020 at 05:38:32PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > Currently we have pci_info() message in the beginning of > edr_handle_event() function, which will be printing > notification details every-time firmware sends ACPI SYSTEM > level events. This will pollute the dmesg logs for systems > that has lot for ACPI system level notifications. So change > the log-level to pci_dbg, and add a new info log for EDR > events. > > Signed-off-by: Kuppuswamy Sathyanarayanan I dropped the pci_dbg() of all events, since there's a way to get those logs from ACPI already (see acpi_ev_queue_notify_request(); I didn't say it was *easy* :)) and applied this to pci/error for v5.8, thanks! > --- > drivers/pci/pcie/edr.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/pcie/edr.c b/drivers/pci/pcie/edr.c > index 594622a6cb16..e346c82559fa 100644 > --- a/drivers/pci/pcie/edr.c > +++ b/drivers/pci/pcie/edr.c > @@ -148,11 +148,13 @@ static void edr_handle_event(acpi_handle handle, u32 event, void *data) > pci_ers_result_t estate = PCI_ERS_RESULT_DISCONNECT; > u16 status; > > - pci_info(pdev, "ACPI event %#x received\n", event); > + pci_dbg(pdev, "ACPI event %#x received\n", event); > > if (event != ACPI_NOTIFY_DISCONNECT_RECOVER) > return; > > + pci_info(pdev, "EDR event received\n"); > + > /* Locate the port which issued EDR event */ > edev = acpi_dpc_port_get(pdev); > if (!edev) { > -- > 2.17.1 >