From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F38FC55199 for ; Mon, 27 Apr 2020 06:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4E182075B for ; Mon, 27 Apr 2020 06:46:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=flygoat.com header.i=@flygoat.com header.b="ipmZLB70" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbgD0Gqh (ORCPT ); Mon, 27 Apr 2020 02:46:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbgD0Gqh (ORCPT ); Mon, 27 Apr 2020 02:46:37 -0400 Received: from vultr.net.flygoat.com (vultr.net.flygoat.com [IPv6:2001:19f0:6001:3633:5400:2ff:fe8c:553]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4CAC061A0F; Sun, 26 Apr 2020 23:46:37 -0700 (PDT) Received: from flygoat-x1e (unknown [IPv6:240e:390:491:f2b0::d68]) by vultr.net.flygoat.com (Postfix) with ESMTPSA id 491202049F; Mon, 27 Apr 2020 06:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=flygoat.com; s=vultr; t=1587969996; bh=87cY8c65SZbqmYxYzk6T3jS7ROhx/jS7jol+umwWuSU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ipmZLB70pSVEu9CTWQUAPnv8VwbpFKilRfFvtvs2qQqppq+N6gnGsLm272ScTwsAT pQOSD3mKgw1ZTRqT7P7EKI1Lgm7jEDUPAYpZJRW3emSSkbETQupWpVcLckr+fRsdS1 WIGijRv/PVDI/Uqt82jPlUetvVCk4jW4a4UF2H0v3dU8a5drnVxoPFYx0eGXc3vO49 INyafcEamxMEuTGOXCwS5H2uRvboiBRjuOte/zrPwWWini+IkfBdXRgdHFNucyPbTZ CLUVS2jO7mdz1TeqKEsmLmAEFGammRDOnWMziS23ni9A8OKCcnY42fU+nJ1LJA2Yrj eBUmFNS0uCXIg== Date: Mon, 27 Apr 2020 14:46:18 +0800 From: Jiaxun Yang To: Huacai Chen Cc: "open list:MIPS" , Bjorn Helgaas , Rob Herring , Thomas Bogendoerfer , Lorenzo Pieralisi , Paul Burton , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, LKML Subject: Re: [PATCH v6 2/5] PCI: Add Loongson PCI Controller support Message-ID: <20200427144618.1e7a642a@flygoat-x1e> In-Reply-To: References: <20200427060551.1372591-1-jiaxun.yang@flygoat.com> <20200427060551.1372591-3-jiaxun.yang@flygoat.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 27 Apr 2020 14:29:34 +0800 Huacai Chen wrote: > Hi, Jiaxun, > > On Mon, Apr 27, 2020 at 2:06 PM Jiaxun Yang > wrote: > > > > This controller can be found on Loongson-2K SoC, Loongson-3 > > systems with RS780E/LS7A PCH. > > > > The RS780E part of code was previously located at > > arch/mips/pci/ops-loongson3.c and now it can use generic PCI > > driver implementation. > > > > Signed-off-by: Jiaxun Yang > > > > -- > > v2: > > - Clean up according to rob's suggestions > > - Claim that it can't work as a module > > v3: > > - Fix a typo > > v4: > > - More clean-ups: Drop flag check, use devfn > > --- > > drivers/pci/controller/Kconfig | 10 + > > drivers/pci/controller/Makefile | 1 + > > drivers/pci/controller/pci-loongson.c | 251 [...] > > +static const struct of_device_id loongson_pci_of_match[] = { > > + { .compatible = "loongson,rs780e-pci", > > + .data = (void *)(FLAG_CFG0), }, > > + { .compatible = "loongson,ls2k-pci", > > + .data = (void *)(FLAG_CFG0 | FLAG_CFG1 | > > FLAG_DEV_FIX), }, > > + { .compatible = "loongson,ls7a-pci", > > + .data = (void *)(FLAG_CFG0 | FLAG_CFG1 | > > FLAG_DEV_FIX), }, > I suggest to use alpha-betical order here: ls2k, ls7a and rs780 at > last. Thanks for pointing out this minor issue. I put rs780e at first at it appears to be the first system using this driver. If there is no more review suggestion I'll send out next revision very soon. [...] -- Jiaxun Yang