From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D19C83004 for ; Tue, 28 Apr 2020 08:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B0A12064A for ; Tue, 28 Apr 2020 08:26:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbgD1I0Y (ORCPT ); Tue, 28 Apr 2020 04:26:24 -0400 Received: from foss.arm.com ([217.140.110.172]:47616 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbgD1I0Y (ORCPT ); Tue, 28 Apr 2020 04:26:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1EBE230E; Tue, 28 Apr 2020 01:26:24 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 746133F305; Tue, 28 Apr 2020 01:26:22 -0700 (PDT) Date: Tue, 28 Apr 2020 09:26:17 +0100 From: Lorenzo Pieralisi To: Geert Uytterhoeven Cc: Bjorn Helgaas , Marek Vasut , linux-pci , Kazufumi Ikeda , Gaku Inami , Marek Vasut , Geert Uytterhoeven , Phil Edworthy , Simon Horman , Wolfram Sang , Linux-Renesas , Vaibhav Gupta Subject: Re: [PATCH V3] PCI: rcar: Add the suspend/resume for pcie-rcar driver Message-ID: <20200428082617.GA12459@e121166-lin.cambridge.arm.com> References: <20200427174138.GA207841@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Apr 27, 2020 at 10:08:52PM +0200, Geert Uytterhoeven wrote: > Hi Bjorn, > > On Mon, Apr 27, 2020 at 7:41 PM Bjorn Helgaas wrote: > > On Sat, Apr 25, 2020 at 10:55:21AM +0200, Geert Uytterhoeven wrote: > > > On Fri, Apr 24, 2020 at 9:57 PM Bjorn Helgaas wrote: > > > > [+cc Vaibhav] > > > > > > > > Alternate less redundant subject: > > > > > > > > PCI: rcar: Add suspend/resume support > > > > > > Note that there's both pcie-rcar.c (this driver, for R-Car Gen2 and Gen3 > > > PCIe) and pci-rcar-gen2.c (for R-Car Gen2 PCI). > > > People tend to use the prefix "PCI: rcar: " for both :-( > > > > Yeah, that's pretty broken, thanks for pointing this out! > > > > For most drivers we use a chipset name ("keystone", "imx6", "tegra", > > etc) as the changlog tag. That's nice because it gives space for > > multiple drivers from the same vendor, but I don't know anything > > similarly specific for the R-Car drivers. > > > > pci-rcar-gen2.c seems to be for some sort of internal Conventional PCI > > AFAIUI it's some internal PCI glue to the *HCI USB controller. > > > bus? The "gen2" is confusing because "Gen 2" is more commonly used > > for PCIe than for Conventional PCI. > > The "Gen2" applies to "R-Car", not to "PCI". Wicked :) ! > > I would propose keeping "rcar" for the PCIe driver and using > > "rcar-pci" for the Conventional PCI one, but the Conventional PCI one > > (/me resists against bike-shedding) I'd agree with Bjorn - I don't know, internal vs external seems artificial. Certainly gen2 is misleading, it does not take much to improve it. > > (pci-rcar-gen2.c) seems pretty inactive. The most recent commits are > > from 2018, and they're trivial cleanups. So I'm doubtful that anybody > > will remember when the next change comes in. > > I guess pci-rcar-gen2.c is simpler and more mature ;-) > R-Car Gen2 SoCs have both (internal) PCI and PCIe, so the two drivers > can be used together on the same hardware. I'd remove gen2 to start with, you are better placed to know the internals to come up with something significant. Lorenzo