From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: Will Deacon <will@kernel.org>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Mans Rullgard <mans@mansr.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Robert Richter <rrichter@marvell.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Toan Le <toan@os.amperecomputing.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Jonathan Chocron <jonnyc@amazon.com>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 0/3] PCI: Modularize host-generic
Date: Fri, 1 May 2020 15:16:26 +0100 [thread overview]
Message-ID: <20200501141626.GA7398@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200409234923.21598-1-robh@kernel.org>
On Thu, Apr 09, 2020 at 05:49:20PM -0600, Rob Herring wrote:
> This is part of a larger effort to modularize ARCH_VEXPRESS. In
> particular, the Arm FVP platforms use the host-generic driver. This
> conversion was straight-forward. I didn't convert the other ECAM drivers
> using host-common to modules, but am happy to do so if there's a strong
> desire to do so.
>
> In the process, I noticed that 'const' was being dropped from the match
> table .data pointer, so the first patch constifies struct pci_ecam_ops.
> I started trying to constify pci_ops too, but that became a never ending
> treewide rabbit hole. So I ended up with a cast when we assign pci_ops
> from pci_ecam_ops.
>
> Rob
Hi Bjorn,
if you don't have any objections I'd need your ACK to take this
series.
Thanks,
Lorenzo
> Rob Herring (3):
> PCI: Constify struct pci_ecam_ops
> PCI: host-generic: Support building as modules
> PCI: host-generic: Eliminate pci_host_common_probe wrappers
>
> arch/arm64/kernel/pci.c | 4 ++--
> drivers/acpi/pci_mcfg.c | 8 +++----
> drivers/pci/controller/Kconfig | 4 ++--
> drivers/pci/controller/dwc/pcie-al.c | 2 +-
> drivers/pci/controller/dwc/pcie-hisi.c | 19 +++++------------
> drivers/pci/controller/pci-host-common.c | 18 ++++++++++++----
> drivers/pci/controller/pci-host-generic.c | 26 +++++++----------------
> drivers/pci/controller/pci-thunder-ecam.c | 14 ++++++------
> drivers/pci/controller/pci-thunder-pem.c | 16 ++++++--------
> drivers/pci/controller/pci-xgene.c | 4 ++--
> drivers/pci/controller/pcie-tango.c | 9 +++++---
> drivers/pci/ecam.c | 10 ++++++---
> drivers/pci/setup-bus.c | 1 +
> include/linux/pci-acpi.h | 2 +-
> include/linux/pci-ecam.h | 25 +++++++++++-----------
> 15 files changed, 78 insertions(+), 84 deletions(-)
>
> --
> 2.20.1
next prev parent reply other threads:[~2020-05-01 14:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 23:49 [PATCH 0/3] PCI: Modularize host-generic Rob Herring
2020-04-09 23:49 ` [PATCH 1/3] PCI: Constify struct pci_ecam_ops Rob Herring
2020-04-14 10:22 ` Catalin Marinas
2020-04-09 23:49 ` [PATCH 2/3] PCI: host-generic: Support building as modules Rob Herring
2020-04-28 13:31 ` Will Deacon
2020-04-09 23:49 ` [PATCH 3/3] PCI: host-generic: Eliminate pci_host_common_probe wrappers Rob Herring
2020-05-01 14:16 ` Lorenzo Pieralisi [this message]
2020-05-01 14:46 ` [PATCH 0/3] PCI: Modularize host-generic Bjorn Helgaas
2020-05-01 15:38 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501141626.GA7398@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=jonnyc@amazon.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=mans@mansr.com \
--cc=marc.w.gonzalez@free.fr \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=rrichter@marvell.com \
--cc=toan@os.amperecomputing.com \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).