From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 565CCC4724C for ; Fri, 1 May 2020 15:38:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 324652495B for ; Fri, 1 May 2020 15:38:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729050AbgEAPij (ORCPT ); Fri, 1 May 2020 11:38:39 -0400 Received: from foss.arm.com ([217.140.110.172]:42882 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728865AbgEAPig (ORCPT ); Fri, 1 May 2020 11:38:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0FD7A30E; Fri, 1 May 2020 08:38:35 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 140BF3F68F; Fri, 1 May 2020 08:38:32 -0700 (PDT) Date: Fri, 1 May 2020 16:38:30 +0100 From: Lorenzo Pieralisi To: Rob Herring Cc: Bjorn Helgaas , Will Deacon , Andrew Murray , Catalin Marinas , Mans Rullgard , Marc Gonzalez , Robert Richter , Zhou Wang , Toan Le , "Rafael J. Wysocki" , Len Brown , Jonathan Chocron , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/3] PCI: Modularize host-generic Message-ID: <20200501153830.GD7398@e121166-lin.cambridge.arm.com> References: <20200409234923.21598-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409234923.21598-1-robh@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Apr 09, 2020 at 05:49:20PM -0600, Rob Herring wrote: > This is part of a larger effort to modularize ARCH_VEXPRESS. In > particular, the Arm FVP platforms use the host-generic driver. This > conversion was straight-forward. I didn't convert the other ECAM drivers > using host-common to modules, but am happy to do so if there's a strong > desire to do so. > > In the process, I noticed that 'const' was being dropped from the match > table .data pointer, so the first patch constifies struct pci_ecam_ops. > I started trying to constify pci_ops too, but that became a never ending > treewide rabbit hole. So I ended up with a cast when we assign pci_ops > from pci_ecam_ops. > > Rob > > > Rob Herring (3): > PCI: Constify struct pci_ecam_ops > PCI: host-generic: Support building as modules > PCI: host-generic: Eliminate pci_host_common_probe wrappers > > arch/arm64/kernel/pci.c | 4 ++-- > drivers/acpi/pci_mcfg.c | 8 +++---- > drivers/pci/controller/Kconfig | 4 ++-- > drivers/pci/controller/dwc/pcie-al.c | 2 +- > drivers/pci/controller/dwc/pcie-hisi.c | 19 +++++------------ > drivers/pci/controller/pci-host-common.c | 18 ++++++++++++---- > drivers/pci/controller/pci-host-generic.c | 26 +++++++---------------- > drivers/pci/controller/pci-thunder-ecam.c | 14 ++++++------ > drivers/pci/controller/pci-thunder-pem.c | 16 ++++++-------- > drivers/pci/controller/pci-xgene.c | 4 ++-- > drivers/pci/controller/pcie-tango.c | 9 +++++--- > drivers/pci/ecam.c | 10 ++++++--- > drivers/pci/setup-bus.c | 1 + > include/linux/pci-acpi.h | 2 +- > include/linux/pci-ecam.h | 25 +++++++++++----------- > 15 files changed, 78 insertions(+), 84 deletions(-) Applied to pci/host-generic for v5.8, thanks ! Lorenzo