From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
amurray@thegoodpenguin.co.uk, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH] PCI: dwc: clean up computing of msix_tbl
Date: Tue, 5 May 2020 10:57:23 +0100 [thread overview]
Message-ID: <20200505095723.GB12543@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200420065227.4920-1-jslaby@suse.cz>
On Mon, Apr 20, 2020 at 08:52:27AM +0200, Jiri Slaby wrote:
> Commit 6f5e193bfb55 ("PCI: dwc: Fix dw_pcie_ep_raise_msix_irq() to get
> correct MSI-X table address") overcomplicated the computation of the
> msix_tbl address. Simplify it as it's simply the addr + offset. Provided
> addr is (void *) already.
>
> objdump -d shows no difference after this patch.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Applied to pci/dwc, thanks !
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 1cdcbd102ce8..c815d36905b6 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -433,7 +433,6 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no,
> struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
> struct pci_epf_msix_tbl *msix_tbl;
> struct pci_epc *epc = ep->epc;
> - struct pci_epf_bar *epf_bar;
> u32 reg, msg_data, vec_ctrl;
> unsigned int aligned_offset;
> u32 tbl_offset;
> @@ -446,10 +445,7 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no,
> bir = (tbl_offset & PCI_MSIX_TABLE_BIR);
> tbl_offset &= PCI_MSIX_TABLE_OFFSET;
>
> - epf_bar = ep->epf_bar[bir];
> - msix_tbl = epf_bar->addr;
> - msix_tbl = (struct pci_epf_msix_tbl *)((char *)msix_tbl + tbl_offset);
> -
> + msix_tbl = ep->epf_bar[bir]->addr + tbl_offset;
> msg_addr = msix_tbl[(interrupt_num - 1)].msg_addr;
> msg_data = msix_tbl[(interrupt_num - 1)].msg_data;
> vec_ctrl = msix_tbl[(interrupt_num - 1)].vector_ctrl;
> --
> 2.26.1
>
prev parent reply other threads:[~2020-05-05 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 6:52 Jiri Slaby
2020-05-05 9:57 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505095723.GB12543@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=jslaby@suse.cz \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--subject='Re: [PATCH] PCI: dwc: clean up computing of msix_tbl' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).