From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> To: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: linus.walleij@linaro.org, amurray@thegoodpenguin.co.uk, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in 'v3_pci_probe()' Date: Tue, 5 May 2020 12:04:24 +0100 [thread overview] Message-ID: <20200505110423.GC13446@e121166-lin.cambridge.arm.com> (raw) In-Reply-To: <20200418081637.1585-1-christophe.jaillet@wanadoo.fr> On Sat, Apr 18, 2020 at 10:16:37AM +0200, Christophe JAILLET wrote: > IF we fails somewhere in 'v3_pci_probe()', we need to free 'host'. > Use the managed version of 'pci_alloc_host_bridge()' to do that easily. > The use of managed resources is already widely used in this driver. > > Fixes: 68a15eb7bd0c ("PCI: v3-semi: Add V3 Semiconductor PCI host driver") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Fixes could be older than this commit, but this is as far as git can go. > > There is also a 'clk_prepare_enable()' which looks un-ballanced. I don't > know if it can be an issue. > > Compile tested only. > --- > drivers/pci/controller/pci-v3-semi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/v3-semi, thanks ! Lorenzo > diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c > index bd05221f5a22..ddcb4571a79b 100644 > --- a/drivers/pci/controller/pci-v3-semi.c > +++ b/drivers/pci/controller/pci-v3-semi.c > @@ -720,7 +720,7 @@ static int v3_pci_probe(struct platform_device *pdev) > int irq; > int ret; > > - host = pci_alloc_host_bridge(sizeof(*v3)); > + host = devm_pci_alloc_host_bridge(dev, sizeof(*v3)); > if (!host) > return -ENOMEM; > > -- > 2.20.1 >
prev parent reply other threads:[~2020-05-05 11:04 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-18 8:16 Christophe JAILLET 2020-04-19 9:51 ` Linus Walleij 2020-05-05 11:04 ` Lorenzo Pieralisi [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200505110423.GC13446@e121166-lin.cambridge.arm.com \ --to=lorenzo.pieralisi@arm.com \ --cc=amurray@thegoodpenguin.co.uk \ --cc=bhelgaas@google.com \ --cc=christophe.jaillet@wanadoo.fr \ --cc=kernel-janitors@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --subject='Re: [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in '\''v3_pci_probe()'\''' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).