Re: [PATCH] PCI: pcie-rcar: Cache PHY init function pointer

From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: linux-pci@vger.kernel.org,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] PCI: pcie-rcar: Cache PHY init function pointer
Date: Tue, 5 May 2020 19:02:14 +0100	[thread overview]
Message-ID: <20200505180214.GA18468@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <717765f1-b5be-a436-20d6-d0a95f58cbdc@gmail.com>

On Fri, May 01, 2020 at 10:42:06PM +0200, Marek Vasut wrote:
> On 4/28/20 10:32 AM, Lorenzo Pieralisi wrote:
> > On Sun, Apr 26, 2020 at 02:31:47PM +0200, marek.vasut@gmail.com wrote:
> >> From: Marek Vasut <marek.vasut+renesas@gmail.com>
> >>
> >> The PHY initialization function pointer does not change during the
> >> lifetime of the driver instance, it is therefore sufficient to get
> >> the pointer in .probe(), cache it in driver private data, and just
> >> call the function through the cached pointer in .resume().
> >>
> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> >> Cc: Bjorn Helgaas <bhelgaas@google.com>
> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> >> Cc: Wolfram Sang <wsa@the-dreams.de>
> >> Cc: linux-renesas-soc@vger.kernel.org
> >> ---
> >> NOTE: Based on git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> >>       branch pci/rcar
> >> NOTE: The driver tag is now 'pcie-rcar' to distinguish it from pci-rcar-gen2.c
> >> ---
> >>  drivers/pci/controller/pcie-rcar.c | 10 ++++------
> >>  1 file changed, 4 insertions(+), 6 deletions(-)
> > 
> > Squashed in https://patchwork.kernel.org/patch/11438665
> 
> Thanks
> 
> > Do you want me to rename the $SUBJECT (and the branch name while at it)
> > in the patches in my pci/rcar branch ("PCI: pcie-rcar: ...") to start
> > the commit subject tag renaming from this cycle (and in the interim you
> > send a rename for the drivers files ?)
> 
> I don't really have a particular preference either way. I can keep
> marking the drivers with pcie-rcar and pci-rcar tags if that helps
> discern them.

So:

- "rcar" for the PCIe driver
- "rcar-pci" or "rcar-legacy" for the pci-rcar-gen2.c (preference ?
  there is no urgency, no commit queued to rename, it is for future
  code)

Are we OK with that ? If yes I will rewrite the commits subjects
and push out an updated pci/rcar branch.

...DT bindings commit subjects - should I change their tag subject
too ?

Lorenzo