From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4938FC47255 for ; Fri, 8 May 2020 18:51:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22026218AC for ; Fri, 8 May 2020 18:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588963901; bh=G0Uu5w3eBIja3ZOupFgWdBHmfnHRekLsvyYCif+pd5Q=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=o3tZ74tK8zo3FRuqiIAvZhM+3ClURX/iHuFvnFS5LhTAdmdT7NZbucaocDJrJ+fhf zZGM4A6WgTdI4TyNv/DzFTbTs7f0dDsTwGZr5zuNwAhH2lh1w2SUyCpFcEBmK/bj4c UcujHua1Inu18lyxjJweRH/OFY5zPp4b27DaV2vk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbgEHSvk (ORCPT ); Fri, 8 May 2020 14:51:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:59494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726767AbgEHSvk (ORCPT ); Fri, 8 May 2020 14:51:40 -0400 Received: from localhost (mobile-166-175-190-200.mycingular.net [166.175.190.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5A3A207DD; Fri, 8 May 2020 18:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588963900; bh=G0Uu5w3eBIja3ZOupFgWdBHmfnHRekLsvyYCif+pd5Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=kDmaDXrDaXsYKLqNvQ8A9gMAks0N3gYY6dGxvuPenkkFVJspAtgDNT5yoaYzeOZO0 ZcyCjsy2Mo8mAsdsNISutBNbPmgWdxZPKktHB3gs2XbvNolR8NI2jma/Pyq3XUr/08 YupB9oKpgmffnkJN7SxqrHjzqmLOT/1d9tCa0Z0k= Date: Fri, 8 May 2020 13:51:38 -0500 From: Bjorn Helgaas To: Jiaxun Yang Cc: linux-mips@vger.kernel.org, Bjorn Helgaas , Rob Herring , Thomas Bogendoerfer , Huacai Chen , Lorenzo Pieralisi , Paul Burton , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/5] PCI: Don't disable decoding when mmio_always_on is set Message-ID: <20200508185138.GA78849@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428011429.1852081-2-jiaxun.yang@flygoat.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Apr 28, 2020 at 09:14:16AM +0800, Jiaxun Yang wrote: > Don't disable MEM/IO decoding when a device have both non_compliant_bars > and mmio_always_on. > > That would allow us quirk devices with junk in BARs but can't disable > their decoding. > > Signed-off-by: Jiaxun Yang Acked-by: Bjorn Helgaas > --- > drivers/pci/probe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 77b8a145c39b..d9c2c3301a8a 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -1822,7 +1822,7 @@ int pci_setup_device(struct pci_dev *dev) > /* Device class may be changed after fixup */ > class = dev->class >> 8; > > - if (dev->non_compliant_bars) { > + if (dev->non_compliant_bars && !dev->mmio_always_on) { > pci_read_config_word(dev, PCI_COMMAND, &cmd); > if (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) { > pci_info(dev, "device has non-compliant BARs; disabling IO/MEM decoding\n"); > -- > 2.26.0.rc2 >