From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D06FCA90AF for ; Tue, 12 May 2020 15:45:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D2EA206D6 for ; Tue, 12 May 2020 15:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589298352; bh=UdH39dbGEYs/Fs/sV61v1NfDwdHNw73/lzebAGliuEw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bgf+MSCNN1mngNwW8KIdAX0Ga5YIKvOBPFG/u+gFrD9bHEd/WnAVKvsY2WstH1pxo HYVYTKoe6X9qP8QuvuEGqgdkQ8E12J5fABJHaNikUDKsM9Jl/IlBW8YJ28yOjNnq1w 9Ajr0pOGGbaowAw72lumlaUJsvx3ACFhVCOsxQko= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726889AbgELPps (ORCPT ); Tue, 12 May 2020 11:45:48 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:38605 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbgELPps (ORCPT ); Tue, 12 May 2020 11:45:48 -0400 Received: by mail-ot1-f67.google.com with SMTP id m33so10871642otc.5; Tue, 12 May 2020 08:45:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wjhqZR0KFtDODzXTbFPWHQLNPIl2BEjWfgjvJzwWtyM=; b=DXdivuamiPck6uKR1utxJP9eYvBK8zO8w62MapXJMpjeEK+/xSvnLLZhBJ1QwKMdOf VIjkP8q3P21ERM2InRTa580tE/HfLQwzi9jc22+fJ9jplwflr2EThPE1TJjfLvV4Imnf dBmSP/q5m8pCi1wYjrclErYqgeHfbp5YtJwKa/2CB7gaxIi82KuIn9wqnki2AaOX/qIp i+xaDUGNv6Dm1GEtMNrTLJE2X+6LJggN8rmAG43Upm91/5UFhERZNL2GEIfkvF138oea ipBpwKNnv7XPehFzFp6rO6UAc9F0lPjyz2cAs8myU81/0fOKmvx3hv8EwS0DCDnqlssx BLPA== X-Gm-Message-State: AGi0PuZOJJzMthXFSrTcvXuRZe69ZE6RMh+LxermEnfFV2ix3Ql3EahY eWaqe/MCC10vjs//CHNdUg== X-Google-Smtp-Source: APiQypL6/T/FPzkcOYcltEodmiZvU7X6jDCHWnt/PGwkj5Xv0c65PIVAc4kQx2qq4cpuP4NKW2EpCw== X-Received: by 2002:a05:6830:1e25:: with SMTP id t5mr16362224otr.358.1589298347136; Tue, 12 May 2020 08:45:47 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d61sm3517309otb.58.2020.05.12.08.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 08:45:45 -0700 (PDT) Received: (nullmailer pid 4011 invoked by uid 1000); Tue, 12 May 2020 15:45:44 -0000 Date: Tue, 12 May 2020 10:45:44 -0500 From: Rob Herring To: ansuelsmth@gmail.com Cc: 'Bjorn Andersson' , 'Andy Gross' , 'Bjorn Helgaas' , 'Mark Rutland' , 'Stanimir Varbanov' , 'Lorenzo Pieralisi' , 'Andrew Murray' , 'Philipp Zabel' , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: R: [PATCH v3 08/11] devicetree: bindings: pci: document PARF params bindings Message-ID: <20200512154544.GA823@bogus> References: <20200430220619.3169-1-ansuelsmth@gmail.com> <20200430220619.3169-9-ansuelsmth@gmail.com> <20200507181044.GA15159@bogus> <062301d624a6$8be610d0$a3b23270$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <062301d624a6$8be610d0$a3b23270$@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, May 07, 2020 at 09:34:35PM +0200, ansuelsmth@gmail.com wrote: > > On Fri, May 01, 2020 at 12:06:15AM +0200, Ansuel Smith wrote: > > > It is now supported the editing of Tx De-Emphasis, Tx Swing and > > > Rx equalization params on ipq8064. Document this new optional params. > > > > > > Signed-off-by: Ansuel Smith > > > --- > > > .../devicetree/bindings/pci/qcom,pcie.txt | 36 +++++++++++++++++++ > > > 1 file changed, 36 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt > > b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > > > index 6efcef040741..8cc5aea8a1da 100644 > > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt > > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > > > @@ -254,6 +254,42 @@ > > > - "perst-gpios" PCIe endpoint reset signal line > > > - "wake-gpios" PCIe endpoint wake signal line > > > > > > +- qcom,tx-deemph-gen1: > > > + Usage: optional (available for ipq/apq8064) > > > + Value type: > > > + Definition: Gen1 De-emphasis value. > > > + For ipq806x should be set to 24. > > > > Unless these need to be tuned per board, then the compatible string for > > ipq806x should imply all these settings. > > > > It was requested by v2 to make this settings tunable. These don't change are > all the same for every ipq806x SoC. The original implementation had this > value hardcoded for ipq806x. Should I restore this and drop this patch? Yes, please. Rob