From: "Pali Rohár" <firstname.lastname@example.org> To: Lorenzo Pieralisi <email@example.com> Cc: firstname.lastname@example.org, "Bjorn Helgaas" <email@example.com>, "Jason Cooper" <firstname.lastname@example.org>, "Andrew Lunn" <email@example.com>, "Gregory Clement" <firstname.lastname@example.org>, "Sebastian Hesselbarth" <email@example.com>, "Rob Herring" <firstname.lastname@example.org>, "Andrew Murray" <email@example.com>, "Remi Pommarel" <firstname.lastname@example.org>, "Marek Behún" <email@example.com>, "Tomasz Maciej Nowak" <firstname.lastname@example.org>, Xogium <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v4 00/12] PCI: aardvark: Fix support for Turris MOX and Compex wifi cards Date: Wed, 13 May 2020 13:59:40 +0200 [thread overview] Message-ID: <20200513115940.fiemtnxfqcyqo6ik@pali> (raw) In-Reply-To: <20200513113314.GB32365@e121166-lin.cambridge.arm.com> On Wednesday 13 May 2020 12:33:14 Lorenzo Pieralisi wrote: > On Wed, May 13, 2020 at 01:16:51PM +0200, Pali Rohár wrote: > > On Thursday 30 April 2020 10:06:13 Pali Rohár wrote: > > > Hello, > > > > > > this is the fourth version of the patch series for Armada 3720 PCIe > > > controller (aardvark). It's main purpose is to fix some bugs regarding > > > buggy ath10k cards, but we also found out some suspicious stuff about > > > the driver and the SOC itself, which we try to address. > > > > > > Patches are available also in my git branch pci-aardvark: > > > https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=pci-aardvark > > > > Hello! Thanks everybody for review and testing of this patch series. > > > > I would like to ask, is there something needed to fix / modify in this > > patch series? If everything is OK, would you Bjorn or Lorenzo take this > > patch series into your tree? > > We need Thomas' ACK on the series. We don't have this HW and > we comment on the generic code, Thomas owns it and must check that > what you are changing is sound. Ok, we will wait for Thomas ACK/review. > On patch 5 I share Rob's concerns - it does not make much sense > to have something driver specific there, need to look further. I fully understand yours concerns. I wanted to solve it. Problem is that I really do not know which timeout is there applicable. I read information about PERST# more times but I was not able to clearly deduce that minimal timeout/delay needed for this reset scenario. So what I was able to do are just experiments. I found out what is the minimal needed time to correctly initialize wifi cars which I used for testing. You can look into my previous email  where I wrote which timeouts are used by which drivers. Basically every driver is using its own custom timeout and this is something which should be fixed / improved. In my opinion authors tested their own (wifi) cards and measured minimal timeout needed for initializing them. So somebody with deeper PCI knowledge should look at this PERST# problem and try to address it. After it happens I see there two scenarios: 1) Timeout according to specification/authority is lower than what we currently use. In this case it would mean that we have buggy wifi cards (and we already know that people reported issues with Compex cards) and we would have to stay with higher timeout. Probably we can define common macro with timeout value and use it. 2) Timeout according to specification/authority is bigger then what we currently use. In this case there is no problem to increase it, card would be just longer in reset state. What could be problematic for somebody is that this increase boot / initialization time.  - https://lore.kernel.org/linux-pci/20200424092546.25p3hdtkehohe3xw@pali/
next prev parent reply other threads:[~2020-05-13 11:59 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-30 8:06 Pali Rohár 2020-04-30 8:06 ` [PATCH v4 01/12] PCI: aardvark: Train link immediately after enabling training Pali Rohár 2020-05-04 15:50 ` Bjorn Helgaas 2020-05-07 21:05 ` Rob Herring 2020-04-30 8:06 ` [PATCH v4 02/12] PCI: aardvark: Don't blindly enable ASPM L0s and don't write to read-only register Pali Rohár 2020-05-07 21:07 ` Rob Herring 2020-04-30 8:06 ` [PATCH v4 03/12] PCI: of: Zero max-link-speed value is invalid Pali Rohár 2020-05-07 21:07 ` Rob Herring 2020-04-30 8:06 ` [PATCH v4 04/12] PCI: aardvark: Improve link training Pali Rohár 2020-05-07 21:10 ` Rob Herring 2020-04-30 8:06 ` [PATCH v4 05/12] PCI: aardvark: Issue PERST via GPIO Pali Rohár 2020-04-30 8:22 ` Pali Rohár 2020-05-07 21:20 ` Rob Herring 2020-04-30 8:06 ` [PATCH v4 06/12] PCI: aardvark: Add FIXME comment for PCIE_CORE_CMD_STATUS_REG access Pali Rohár 2020-05-07 21:20 ` Rob Herring 2020-04-30 8:06 ` [PATCH v4 07/12] PCI: aardvark: Add PHY support Pali Rohár 2020-05-07 21:23 ` Rob Herring 2020-04-30 8:06 ` [PATCH v4 08/12] PCI: aardvark: Replace custom macros by standard linux/pci_regs.h macros Pali Rohár 2020-05-04 15:52 ` Bjorn Helgaas 2020-05-07 21:24 ` Rob Herring 2020-04-30 8:06 ` [PATCH v4 09/12] dt-bindings: PCI: aardvark: Describe new properties Pali Rohár 2020-05-07 21:25 ` Rob Herring 2020-04-30 8:06 ` [PATCH v4 10/12] arm64: dts: marvell: armada-37xx: Set pcie_reset_pin to gpio function Pali Rohár 2020-04-30 8:06 ` [PATCH v4 11/12] arm64: dts: marvell: armada-37xx: Move PCIe comphy handle property Pali Rohár 2020-04-30 8:06 ` [PATCH v4 12/12] arm64: dts: marvell: armada-37xx: Move PCIe max-link-speed property Pali Rohár 2020-05-04 15:50 ` Bjorn Helgaas 2020-05-08 13:11 ` [PATCH v4 00/12] PCI: aardvark: Fix support for Turris MOX and Compex wifi cards Tomasz Maciej Nowak 2020-05-13 11:16 ` Pali Rohár 2020-05-13 11:33 ` Lorenzo Pieralisi 2020-05-13 11:59 ` Pali Rohár [this message] 2020-05-13 11:56 ` Thomas Petazzoni 2020-05-17 15:57 ` Gregory CLEMENT 2020-05-18 10:30 ` Pali Rohár 2020-05-18 13:46 ` Lorenzo Pieralisi 2020-05-18 13:50 ` Marek Behun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200513115940.fiemtnxfqcyqo6ik@pali \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v4 00/12] PCI: aardvark: Fix support for Turris MOX and Compex wifi cards' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).