From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: linux-pci@vger.kernel.org, qemu-devel@nongnu.org,
Bjorn Helgaas <helgaas@kernel.org>,
virtualization@lists.linux-foundation.org,
Christoph Hellwig <hch@lst.de>,
Andrzej Jakowski <andrzej.jakowski@linux.intel.com>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH v3 1/2] PCI: vmd: Filter resource type bits from shadow register
Date: Fri, 29 May 2020 11:33:15 +0100 [thread overview]
Message-ID: <20200529103315.GC12270@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200528030240.16024-3-jonathan.derrick@intel.com>
On Wed, May 27, 2020 at 11:02:39PM -0400, Jon Derrick wrote:
> Versions of VMD with the Host Physical Address shadow register use this
> register to calculate the bus address offset needed to do guest
> passthrough of the domain. This register shadows the Host Physical
> Address registers including the resource type bits. After calculating
> the offset, the extra resource type bits lead to the VMD resources being
> over-provisioned at the front and under-provisioned at the back.
>
> Example:
> pci 10000:80:02.0: reg 0x10: [mem 0xf801fffc-0xf803fffb 64bit]
>
> Expected:
> pci 10000:80:02.0: reg 0x10: [mem 0xf8020000-0xf803ffff 64bit]
>
> If other devices are mapped in the over-provisioned front, it could lead
> to resource conflict issues with VMD or those devices.
>
> Fixes: a1a30170138c9 ("PCI: vmd: Fix shadow offsets to reflect spec changes")
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> ---
> drivers/pci/controller/vmd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Hi Jon,
it looks like I can take this patch for v5.8 whereas patch 2 depends
on the QEMU changes acceptance and should probably wait.
Please let me know your thoughts asap and I will try to at least
squeeze this patch in.
Lorenzo
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index dac91d6..e386d4e 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -445,9 +445,11 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
> if (!membar2)
> return -ENOMEM;
> offset[0] = vmd->dev->resource[VMD_MEMBAR1].start -
> - readq(membar2 + MB2_SHADOW_OFFSET);
> + (readq(membar2 + MB2_SHADOW_OFFSET) &
> + PCI_BASE_ADDRESS_MEM_MASK);
> offset[1] = vmd->dev->resource[VMD_MEMBAR2].start -
> - readq(membar2 + MB2_SHADOW_OFFSET + 8);
> + (readq(membar2 + MB2_SHADOW_OFFSET + 8) &
> + PCI_BASE_ADDRESS_MEM_MASK);
> pci_iounmap(vmd->dev, membar2);
> }
> }
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2020-05-29 10:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 3:02 [PATCH v3 0/2] VMD endpoint passthrough support Jon Derrick
2020-05-28 3:02 ` [PATCH v3 FOR QEMU v3] hw/vfio: Add VMD Passthrough Quirk Jon Derrick
2020-05-28 3:02 ` [PATCH v3 1/2] PCI: vmd: Filter resource type bits from shadow register Jon Derrick
2020-05-29 10:33 ` Lorenzo Pieralisi [this message]
2020-05-29 15:53 ` Derrick, Jonathan
2020-05-29 16:18 ` Lorenzo Pieralisi
2020-06-11 21:16 ` Derrick, Jonathan
2020-06-12 13:54 ` Lorenzo Pieralisi
2020-06-12 15:11 ` Derrick, Jonathan
2020-05-28 3:02 ` [PATCH v3 2/2] PCI: vmd: Use Shadow MEMBAR registers for QEMU/KVM guests Jon Derrick
2020-07-06 9:16 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529103315.GC12270@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=alex.williamson@redhat.com \
--cc=andrzej.jakowski@linux.intel.com \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).