[PATCH v2 0/3] pci: enforce usage of 'pci_channel_state_t'

* [PATCH v2 0/3] pci: enforce usage of 'pci_channel_state_t'
@ 2020-07-02 16:26 Luc Van Oostenryck
  2020-07-02 16:26 ` [PATCH v2 1/3] pci: use 'pci_channel_state_t' instead of 'enum pci_channel_state' Luc Van Oostenryck
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Luc Van Oostenryck @ 2020-07-02 16:26 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: linux-pci, linux-kernel, Luc Van Oostenryck

The definition of pci_channel_io_normal and friends is relatively
complicated and ugly:
	typedef unsigned int __bitwise pci_channel_state_t;
	enum pci_channel_state {
		pci_channel_io_normal = (__force pci_channel_state_t) 1,
		...
	};

This is clearly motivated by a desire to have some strong typing
for this constants but:
* in C enums are weakly typed (they're essentially the same as 'int')
* sparse only allow to define bitwise ints, not bitwise enums.

This series is a preparation step to introduce bitwise enums.
This would allow to define these constant without having to use
the force cast:
	enum __bitwise pci_channel_state {
		pci_channel_io_normal = 1,
		...
	};
or, equivalently:
	typedef enum __bitwise {
		pci_channel_io_normal = 1,
		...
	} pci_channel_state_t;

Note: the first patch is, I think, uncontroversial, the other ones
      less so but can be safely dropped.

Changes since v1:
* add missing conversion
* try to avoid using 'enum pci_channel_state' in include/linux/pci.h
* try to avoid using 'enum pci_channel_state' in the documentation

Luc Van Oostenryck (3):
  pci: use 'pci_channel_state_t' instead of 'enum pci_channel_state'
  pci: use anonymous 'enum' instead of 'enum pci_channel_state'
  pci: update to doc to use 'pci_channel_state_t'

 Documentation/PCI/pci-error-recovery.rst    | 8 ++++----
 arch/powerpc/kernel/eeh_driver.c            | 2 +-
 drivers/block/rsxx/core.c                   | 2 +-
 drivers/dma/ioat/init.c                     | 2 +-
 drivers/media/pci/ngene/ngene-cards.c       | 2 +-
 drivers/misc/genwqe/card_base.c             | 2 +-
 drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
 drivers/net/ethernet/intel/ice/ice_main.c   | 2 +-
 drivers/net/ethernet/intel/ixgb/ixgb_main.c | 4 ++--
 drivers/net/ethernet/sfc/efx.c              | 2 +-
 drivers/net/ethernet/sfc/falcon/efx.c       | 2 +-
 drivers/pci/pci.h                           | 2 +-
 drivers/pci/pcie/err.c                      | 4 ++--
 drivers/pci/pcie/portdrv_pci.c              | 2 +-
 drivers/scsi/aacraid/linit.c                | 2 +-
 drivers/scsi/sym53c8xx_2/sym_glue.c         | 2 +-
 drivers/staging/qlge/qlge_main.c            | 2 +-
 include/linux/pci.h                         | 4 ++--
 18 files changed, 24 insertions(+), 24 deletions(-)

-- 
2.27.0

^ permalink raw reply	[flat|nested] 5+ messages in thread