Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Daire.McNamara@microchip.com
Cc: amurray@thegoodpenguin.co.uk, robh+dt@kernel.org,
	lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org,
	bhelgaas@google.com, devicetree@vger.kernel.org,
	david.abdurachmanov@gmail.com
Subject: Re: [PATCH v12 0/2] PCI: microchip: Add host driver for Microchip PCIe controller
Date: Mon, 6 Jul 2020 19:07:25 -0500
Message-ID: <20200707000551.GA174271@bjorn-Precision-5520> (raw)
In-Reply-To: <97e528fd7582186d7db4073c78d72601b2ce553f.camel@microchip.com>

On Thu, Jul 02, 2020 at 03:37:12PM +0000, Daire.McNamara@microchip.com wrote:
> This v12 patch adds support for the Microchip PCIe PolarFire PCIe
> controller when configured in host (Root Complex) mode.

> Daire McNamara (2):
>   PCI: microchip: Add host driver for Microchip PCIe controller
>   PCI: microchip: Add host driver for Microchip PCIe controller

Hi Daire,

I see this in the lore archive:
https://lore.kernel.org/linux-pci/97e528fd7582186d7db4073c78d72601b2ce553f.camel@microchip.com/

but

  - It's not threaded correctly.  The 1/2 and 2/2 patches should be
    responses to the 0/2 cover letter.  The fact that they're not
    means one cannot navigate through the series on
    https://lore.kernel.org.

  - For some reason none of these made it to me directly even though
    I'm in the To: list as well as subscribed to the linux-pci list.
    They *do* appear in both patchwork and lore, and I think they both
    get things via the linux-pci list, so I don't know what's wrong.

    I did correct Rob's email address; maybe that was part of it?

  - The patches should have different subjects.  The DT binding should
    have a subject that matches the history in
    Documentation/devicetree/bindings/pci/, e.g., something like:

    dt-bindings: PCI: microchip: Add Microchip PolarFire host binding

  - The commit logs should be good English; for example, they should
    start with a capital letter.

>  .../bindings/pci/microchip,pcie-host.yaml     |  93 +++
>  drivers/pci/controller/Kconfig                |   9 +
>  drivers/pci/controller/Makefile               |   1 +
>  drivers/pci/controller/pcie-microchip-host.c  | 683 ++++++++++++++++++
>  4 files changed, 786 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
>  create mode 100644 drivers/pci/controller/pcie-microchip-host.c
> 
> 
> base-commit: cd77006e01b3198c75fb7819b3d0ff89709539bb
> -- 
> 2.17.1
> 

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 15:37 Daire.McNamara
2020-07-07  0:07 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707000551.GA174271@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=Daire.McNamara@microchip.com \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=bhelgaas@google.com \
    --cc=david.abdurachmanov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org
	public-inbox-index linux-pci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git