From: Bjorn Helgaas <helgaas@kernel.org>
To: wang.yi59@zte.com.cn
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
wang.liang82@zte.com.cn, liao.pingfang@zte.com.cn
Subject: Re: [PATCH] PCI: Replace kmalloc with kzalloc in the comment/message
Date: Wed, 8 Jul 2020 10:29:42 -0500 [thread overview]
Message-ID: <20200708152942.GA454574@bjorn-Precision-5520> (raw)
In-Reply-To: <202007081722099680673@zte.com.cn>
On Wed, Jul 08, 2020 at 05:22:09PM +0800, wang.yi59@zte.com.cn wrote:
> Hi Bjorn,
>
> Thanks for your review and patience on the datails :)
>
> > On Fri, May 29, 2020 at 09:01:59AM +0800, Yi Wang wrote:
> > > From: Liao Pingfang <liao.pingfang@zte.com.cn>
> > >
> > > Use kzalloc instead of kmalloc in the comment/message according to
> > > the previous kzalloc() call.
> > >
> > > Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> >
> > I would be happy to apply this, but this needs to show a connection
> > between Liao Pingfang and Yi Wang.
> >
> > Ideally this patch would be sent directly by Liao Pingfang. The
> > sender should at least appear in the Signed-off-by chain. See
> > Documentation/process/submitting-patches.rst
>
> According to our company security policy, only a few people have
> access to send email outside of company, so this patch is sent by
> Yi Wang and the author is Liao Pingfang actually.
Please take a look at Documentation/process/submitting-patches.rst.
Specifically, it says:
Notably, the last Signed-off-by: must always be that of the
developer submitting the patch.
You are submitting the patch, but you didn't add a Signed-off-by.
Of course, adding your Signed-off-by means you are agreeing to the
"Developer's Certificate of Origin" (also in that file), which tells
me that the patch is licensed correctly and that you have the right to
submit it.
In addition, your signed-off-by means that if there are issues with
the patch, I will look to you (and Liao Pingfang, obviously) to help
resolve them.
So if that is all acceptable to you, just post this again with your
own signed-off-by below Liao Pingfang's.
Bjorn
next parent reply other threads:[~2020-07-08 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202007081722099680673@zte.com.cn>
2020-07-08 15:29 ` Bjorn Helgaas [this message]
2020-07-09 7:28 [PATCH] PCI: Replace kmalloc with kzalloc in the comment/message Yi Wang
2020-07-09 21:05 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2020-05-29 1:01 Yi Wang
2020-07-07 22:26 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708152942.GA454574@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=liao.pingfang@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).