From: "Marek Behún" <marek.behun@nic.cz>
To: linux-pci@vger.kernel.org
Cc: "Tomasz Maciej Nowak" <tmn505@gmail.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
linux-kernel@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
Xogium <contact@xogium.me>, "Pali Rohár" <pali@kernel.org>,
"kernel test robot" <lkp@intel.com>,
"Marek Behún" <marek.behun@nic.cz>
Subject: [PATCH 1/5] PCI: aardvark: Fix compilation on s390
Date: Wed, 15 Jul 2020 16:25:53 +0200 [thread overview]
Message-ID: <20200715142557.17115-2-marek.behun@nic.cz> (raw)
In-Reply-To: <20200715142557.17115-1-marek.behun@nic.cz>
From: Pali Rohár <pali@kernel.org>
Include linux/gpio/consumer.h instead of linux/gpio.h, as is said in the
latter file.
This was reported by kernel test bot when compiling for s390.
drivers/pci/controller/pci-aardvark.c:350:2: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Werror,-Wimplicit-function-declaration]
drivers/pci/controller/pci-aardvark.c:1074:21: error: implicit declaration of function 'devm_gpiod_get_from_of_node' [-Werror,-Wimplicit-function-declaration]
drivers/pci/controller/pci-aardvark.c:1076:14: error: use of undeclared identifier 'GPIOD_OUT_LOW'
Link: https://lore.kernel.org/r/202006211118.LxtENQfl%25lkp@intel.com
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 5169a9851da ("PCI: aardvark: Issue PERST via GPIO")
Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
---
drivers/pci/controller/pci-aardvark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
index 90ff291c24f0..8caa80b19cf8 100644
--- a/drivers/pci/controller/pci-aardvark.c
+++ b/drivers/pci/controller/pci-aardvark.c
@@ -9,7 +9,7 @@
*/
#include <linux/delay.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
--
2.26.2
next prev parent reply other threads:[~2020-07-15 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 14:25 [PATCH 0/5] PCIe aardvark controller improvements Marek Behún
2020-07-15 14:25 ` Marek Behún [this message]
2020-07-15 14:25 ` [PATCH 2/5] PCI: aardvark: Check for errors from pci_bridge_emul_init() call Marek Behún
2020-07-15 14:25 ` [PATCH 3/5] PCI: pci-bridge-emul: Export API functions Marek Behún
2020-07-15 14:25 ` [PATCH 4/5] PCI: aardvark: Implement driver 'remove' function and allow to build it as module Marek Behún
2020-07-29 18:48 ` Rob Herring
2020-08-03 14:46 ` Pali Rohár
2020-08-03 20:00 ` Rob Herring
2020-08-04 7:24 ` Pali Rohár
2020-07-15 14:25 ` [PATCH 5/5] PCI: aardvark: Move PCIe reset card code to advk_pcie_train_link() Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715142557.17115-2-marek.behun@nic.cz \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=contact@xogium.me \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=pali@kernel.org \
--cc=tmn505@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).