From: Bjorn Helgaas <helgaas@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Fabio Estevam <festevam@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Heiko Stuebner <heiko@sntech.de>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Jingoo Han <jingoohan1@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in>,
Linus Walleij <linus.walleij@linaro.org>,
Lucas Stach <l.stach@pengutronix.de>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Murali Karicheri <m-karicheri2@ti.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Richard Zhu <hongxing.zhu@nxp.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Tom Joseph <tjoseph@cadence.com>, Will Deacon <will@kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 00/19] PCI: Another round of host clean-ups
Date: Wed, 22 Jul 2020 16:06:19 -0500 [thread overview]
Message-ID: <20200722210619.GA1313543@bjorn-Precision-5520> (raw)
In-Reply-To: <20200722022514.1283916-1-robh@kernel.org>
On Tue, Jul 21, 2020 at 08:24:55PM -0600, Rob Herring wrote:
> Here's another round PCI host bridge clean-ups. This one aims to
> reduce the amount of duplication in host probe functions by providing
> more default initialization of the pci_host_bridge. With the prior
> clean-ups, it's now possible to alloc and initialize the pci_host_bridge
> struct from DT in one step.
>
> Patches 2 and 3 drop some pci_host_bridge init. Patches 4-11 clean-up
> handling of root bus number and bus ranges. Patches 12 and 13 are cleanups
> for Cadence driver. Patches 14 and 15 are clean-ups for rCar driver. Patch
> 16 makes missing non-prefetchable region just a warning instead of an
> error in order to work with rcar-gen2. Patch 17 converts rcar-gen2 to not
> use the arm32 specific PCI setup. Patch 18 updates how the DT resource
> parsing is done for all the controller drivers. Any other new controller
> drivers will need updating. Patch 19 moves the default IRQ mapping to
> the bridge init core code.
>
> This is based on my previous series of clean-ups[1].
>
> Compile tested only. Any testing would be appreciated as I don't have
> any of this h/w (well, I have a rock960c, but have not gotten PCIe to work
> on it).
>
> Rob
>
> [1] https://lore.kernel.org/linux-pci/20200522234832.954484-1-robh@kernel.org/
>
> Rob Herring (19):
> PCI: versatile: Drop flag PCI_ENABLE_PROC_DOMAINS
> PCI: Set default bridge parent device
> PCI: Drop unnecessary zeroing of bridge fields
> PCI: aardvark: Use pci_is_root_bus() to check if bus is root bus
> PCI: designware: Use pci_is_root_bus() to check if bus is root bus
> PCI: mobiveil: Use pci_is_root_bus() to check if bus is root bus
> PCI: xilinx-nwl: Use pci_is_root_bus() to check if bus is root bus
> PCI: xilinx: Use pci_is_root_bus() to check if bus is root bus
> PCI: rockchip: Use pci_is_root_bus() to check if bus is root bus
> PCI: rcar: Use pci_is_root_bus() to check if bus is root bus
> PCI: Move setting pci_host_bridge.busnr out of host drivers
> PCI: cadence: Use bridge resources for outbound window setup
> PCI: cadence: Remove private bus number and range storage
> PCI: rcar: Use devm_pci_alloc_host_bridge()
> PCI: rcar: Use struct pci_host_bridge.windows list directly
> PCI: of: Reduce missing non-prefetchable memory region to a warning
> PCI: rcar-gen2: Convert to use modern host bridge probe functions
> PCI: Move DT resource setup into devm_pci_alloc_host_bridge()
> PCI: Set bridge map_irq and swizzle_irq to default functions
>
> .../pci/controller/cadence/pcie-cadence-ep.c | 6 +-
> .../controller/cadence/pcie-cadence-host.c | 65 +++----
> drivers/pci/controller/cadence/pcie-cadence.c | 9 +-
> drivers/pci/controller/cadence/pcie-cadence.h | 8 +-
> drivers/pci/controller/dwc/pci-imx6.c | 2 +-
> drivers/pci/controller/dwc/pci-keystone.c | 4 +-
> .../pci/controller/dwc/pcie-designware-host.c | 28 +--
> drivers/pci/controller/dwc/pcie-designware.h | 2 -
> .../controller/mobiveil/pcie-mobiveil-host.c | 21 +--
> .../pci/controller/mobiveil/pcie-mobiveil.h | 1 -
> drivers/pci/controller/pci-aardvark.c | 25 +--
> drivers/pci/controller/pci-ftpci100.c | 10 --
> drivers/pci/controller/pci-host-common.c | 17 +-
> drivers/pci/controller/pci-loongson.c | 8 -
> drivers/pci/controller/pci-mvebu.c | 4 -
> drivers/pci/controller/pci-rcar-gen2.c | 162 +++++-------------
> drivers/pci/controller/pci-tegra.c | 10 --
> drivers/pci/controller/pci-v3-semi.c | 12 --
> drivers/pci/controller/pci-versatile.c | 13 +-
> drivers/pci/controller/pci-xgene.c | 9 -
> drivers/pci/controller/pcie-altera.c | 10 --
> drivers/pci/controller/pcie-brcmstb.c | 9 -
> drivers/pci/controller/pcie-iproc-platform.c | 10 +-
> drivers/pci/controller/pcie-iproc.c | 3 -
> drivers/pci/controller/pcie-mediatek.c | 16 --
> drivers/pci/controller/pcie-rcar-host.c | 73 +-------
> drivers/pci/controller/pcie-rockchip-host.c | 24 +--
> drivers/pci/controller/pcie-rockchip.h | 1 -
> drivers/pci/controller/pcie-xilinx-nwl.c | 20 +--
> drivers/pci/controller/pcie-xilinx.c | 22 +--
> drivers/pci/of.c | 45 +++--
> drivers/pci/pci.h | 8 +
> drivers/pci/probe.c | 7 +
> include/linux/pci.h | 12 --
> 34 files changed, 160 insertions(+), 516 deletions(-)
Beautiful, thanks for doing all this!
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
next prev parent reply other threads:[~2020-07-22 21:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 2:24 [PATCH 00/19] PCI: Another round of host clean-ups Rob Herring
2020-07-22 2:24 ` [PATCH 01/19] PCI: versatile: Drop flag PCI_ENABLE_PROC_DOMAINS Rob Herring
2020-07-22 2:24 ` [PATCH 02/19] PCI: Set default bridge parent device Rob Herring
2020-07-22 2:24 ` [PATCH 03/19] PCI: Drop unnecessary zeroing of bridge fields Rob Herring
2020-07-22 2:24 ` [PATCH 04/19] PCI: aardvark: Use pci_is_root_bus() to check if bus is root bus Rob Herring
2020-07-22 2:25 ` [PATCH 05/19] PCI: designware: " Rob Herring
2020-07-22 2:25 ` [PATCH 06/19] PCI: mobiveil: " Rob Herring
2020-07-22 2:25 ` [PATCH 07/19] PCI: xilinx-nwl: " Rob Herring
2020-07-22 2:25 ` [PATCH 08/19] PCI: xilinx: " Rob Herring
2020-07-22 2:25 ` [PATCH 09/19] PCI: rockchip: " Rob Herring
2020-07-22 2:25 ` [PATCH 10/19] PCI: rcar: " Rob Herring
2020-07-22 2:25 ` [PATCH 11/19] PCI: Move setting pci_host_bridge.busnr out of host drivers Rob Herring
2020-07-23 15:26 ` Rob Herring
2020-07-23 16:21 ` Lorenzo Pieralisi
2020-07-23 16:55 ` Rob Herring
2020-07-22 2:25 ` [PATCH 12/19] PCI: cadence: Use bridge resources for outbound window setup Rob Herring
2020-07-22 2:25 ` [PATCH 13/19] PCI: cadence: Remove private bus number and range storage Rob Herring
2020-07-22 2:25 ` [PATCH 14/19] PCI: rcar: Use devm_pci_alloc_host_bridge() Rob Herring
2020-07-22 2:25 ` [PATCH 15/19] PCI: rcar: Use struct pci_host_bridge.windows list directly Rob Herring
2020-07-22 2:25 ` [PATCH 16/19] PCI: of: Reduce missing non-prefetchable memory region to a warning Rob Herring
2020-07-22 2:25 ` [PATCH 17/19] PCI: rcar-gen2: Convert to use modern host bridge probe functions Rob Herring
2020-08-04 12:12 ` Geert Uytterhoeven
2020-08-04 15:13 ` Rob Herring
2020-07-22 2:25 ` [PATCH 18/19] PCI: Move DT resource setup into devm_pci_alloc_host_bridge() Rob Herring
2020-07-22 2:25 ` [PATCH 19/19] PCI: Set bridge map_irq and swizzle_irq to default functions Rob Herring
2022-01-11 21:46 ` Bjorn Helgaas
2022-01-12 12:57 ` Jiaxun Yang
2022-01-12 15:19 ` Bjorn Helgaas
2022-01-12 20:08 ` Jiaxun Yang
2022-01-12 21:10 ` Bjorn Helgaas
2022-01-13 17:44 ` Jiaxun Yang
2022-01-12 15:09 ` Rob Herring
2022-01-12 15:32 ` Bjorn Helgaas
2022-01-29 22:34 ` Maciej W. Rozycki
2020-07-22 21:06 ` Bjorn Helgaas [this message]
2020-07-23 10:39 ` [PATCH 00/19] PCI: Another round of host clean-ups Lorenzo Pieralisi
2020-07-23 23:01 ` Bjorn Helgaas
2020-07-24 15:55 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722210619.GA1313543@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=festevam@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=heiko@sntech.de \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m-karicheri2@ti.com \
--cc=m.karthikeyan@mobiveil.co.in \
--cc=marek.vasut+renesas@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.lin@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=will@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).