Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jon Hunter <jonathanh@nvidia.com>,
	PCI <linux-pci@vger.kernel.org>,
	linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] PCI: tegra: Remove PLL power supplies
Date: Mon, 27 Jul 2020 19:21:49 +0200
Message-ID: <20200727172149.GA3683017@ulmo> (raw)
In-Reply-To: <CAL_Jsq+u=oFUAuURy-f8wCzagA-xKJES8RRf=kUSXJHoxOipBQ@mail.gmail.com>


[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

On Mon, Jul 27, 2020 at 10:21:42AM -0600, Rob Herring wrote:
> On Tue, Jun 23, 2020 at 8:55 AM Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The Tegra PCI controller driver doesn't need to control the PLL power
> > supplies directly, but rather uses the pads provided by the XUSB pad
> > controller, which in turn is responsible for supplying power to the
> > PLLs.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> >  drivers/pci/controller/pci-tegra.c | 10 ++--------
> >  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> What's going to happen here with a new dtb and an old kernel? Is it
> going to error out due to missing supplies?

It's not going to error out but fallback to the "dummy" regulator, so
this should be fine from a forwards-compatibility point of view. Though
I didn't think we technically cared about that direction very much.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 14:55 [PATCH v2 1/2] dt-bindings: pci: " Thierry Reding
2020-06-23 14:55 ` [PATCH v2 2/2] PCI: " Thierry Reding
2020-07-16 13:00   ` Thierry Reding
2020-07-16 14:07     ` Lorenzo Pieralisi
2020-07-16 15:06       ` Thierry Reding
2020-07-27 16:21   ` Rob Herring
2020-07-27 17:21     ` Thierry Reding [this message]
2020-07-27 17:43       ` Rob Herring
2020-07-16 12:59 ` [PATCH v2 1/2] dt-bindings: pci: " Thierry Reding
2020-07-17 10:48   ` Lorenzo Pieralisi
2020-07-27 16:17 ` Rob Herring
2020-07-28 10:20 ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727172149.GA3683017@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org
	public-inbox-index linux-pci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git