Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] PCI: Remove pci_lost_interrupt
Date: Wed, 29 Jul 2020 14:26:54 -0500
Message-ID: <20200729192654.GA1956120@bjorn-Precision-5520> (raw)
In-Reply-To: <e328d059-3068-6a40-28df-f81f616d15a0@gmail.com>

On Tue, Jul 28, 2020 at 11:03:41PM +0200, Heiner Kallweit wrote:
> 388c8c16abaf ("PCI: add routines for debugging and handling lost
> interrupts") added pci_lost_interrupt() that apparently never has
> had a single user. So remove it.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied to pci/misc for v5.9, thanks!

> ---
>  drivers/pci/irq.c   | 50 ---------------------------------------------
>  include/linux/pci.h |  7 -------
>  2 files changed, 57 deletions(-)
> 
> diff --git a/drivers/pci/irq.c b/drivers/pci/irq.c
> index a1de501a2..12ecd0aaa 100644
> --- a/drivers/pci/irq.c
> +++ b/drivers/pci/irq.c
> @@ -6,61 +6,11 @@
>   * Copyright (C) 2017 Christoph Hellwig.
>   */
>  
> -#include <linux/acpi.h>
>  #include <linux/device.h>
>  #include <linux/kernel.h>
>  #include <linux/export.h>
>  #include <linux/pci.h>
>  
> -static void pci_note_irq_problem(struct pci_dev *pdev, const char *reason)
> -{
> -	struct pci_dev *parent = to_pci_dev(pdev->dev.parent);
> -
> -	pci_err(pdev, "Potentially misrouted IRQ (Bridge %s %04x:%04x)\n",
> -		dev_name(&parent->dev), parent->vendor, parent->device);
> -	pci_err(pdev, "%s\n", reason);
> -	pci_err(pdev, "Please report to linux-kernel@vger.kernel.org\n");
> -	WARN_ON(1);
> -}
> -
> -/**
> - * pci_lost_interrupt - reports a lost PCI interrupt
> - * @pdev:	device whose interrupt is lost
> - *
> - * The primary function of this routine is to report a lost interrupt
> - * in a standard way which users can recognise (instead of blaming the
> - * driver).
> - *
> - * Returns:
> - * a suggestion for fixing it (although the driver is not required to
> - * act on this).
> - */
> -enum pci_lost_interrupt_reason pci_lost_interrupt(struct pci_dev *pdev)
> -{
> -	if (pdev->msi_enabled || pdev->msix_enabled) {
> -		enum pci_lost_interrupt_reason ret;
> -
> -		if (pdev->msix_enabled) {
> -			pci_note_irq_problem(pdev, "MSIX routing failure");
> -			ret = PCI_LOST_IRQ_DISABLE_MSIX;
> -		} else {
> -			pci_note_irq_problem(pdev, "MSI routing failure");
> -			ret = PCI_LOST_IRQ_DISABLE_MSI;
> -		}
> -		return ret;
> -	}
> -#ifdef CONFIG_ACPI
> -	if (!(acpi_disabled || acpi_noirq)) {
> -		pci_note_irq_problem(pdev, "Potential ACPI misrouting please reboot with acpi=noirq");
> -		/* currently no way to fix acpi on the fly */
> -		return PCI_LOST_IRQ_DISABLE_ACPI;
> -	}
> -#endif
> -	pci_note_irq_problem(pdev, "unknown cause (not MSI or ACPI)");
> -	return PCI_LOST_IRQ_NO_INFORMATION;
> -}
> -EXPORT_SYMBOL(pci_lost_interrupt);
> -
>  /**
>   * pci_request_irq - allocate an interrupt line for a PCI device
>   * @dev:	PCI device to operate on
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 2a2d00e9d..814d652f2 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1053,13 +1053,6 @@ void pci_sort_breadthfirst(void);
>  
>  /* Generic PCI functions exported to card drivers */
>  
> -enum pci_lost_interrupt_reason {
> -	PCI_LOST_IRQ_NO_INFORMATION = 0,
> -	PCI_LOST_IRQ_DISABLE_MSI,
> -	PCI_LOST_IRQ_DISABLE_MSIX,
> -	PCI_LOST_IRQ_DISABLE_ACPI,
> -};
> -enum pci_lost_interrupt_reason pci_lost_interrupt(struct pci_dev *dev);
>  int pci_find_capability(struct pci_dev *dev, int cap);
>  int pci_find_next_capability(struct pci_dev *dev, u8 pos, int cap);
>  int pci_find_ext_capability(struct pci_dev *dev, int cap);
> -- 
> 2.27.0
> 

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 21:03 Heiner Kallweit
2020-07-29 19:26 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729192654.GA1956120@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bhelgaas@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org
	public-inbox-index linux-pci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git