linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq()
@ 2020-08-02 14:25 Krzysztof Wilczyński
  2020-08-02 14:25 ` [PATCH 01/10] PCI: dwc: Remove " Krzysztof Wilczyński
                   ` (10 more replies)
  0 siblings, 11 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:25 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Jingoo Han, Kukjin Kim, Krzysztof Kozlowski, Richard Zhu,
	Lucas Stach, Shawn Guo, Sascha Hauer, Murali Karicheri, Yue Wang,
	Kevin Hilman, Thomas Petazzoni, Jesper Nilsson, Xiaowei Song,
	Binghui Wang, Pratyush Anand, Hou Zhiqiang, Linus Walleij,
	Toan Le, Ley Foon Tan, Shawn Lin, Heiko Stuebner, linux-amlogic,
	linux-arm-kernel, linux-arm-kernel, linux-omap, linux-pci,
	linux-rockchip, linux-samsung-soc, linux-tegra, rfi

At the moment a lot of error handling code would print a duplicated
error message should either the platform_get_irq() or
platform_get_irq_byname() function fails to obtain an IRQ for a device.

There is no need to call the dev_err() function directly to print
a custom message when handling an error from either of these functions
as both are going to display an appropriate error message in case of
a failure.

This series aims to remove surplus call to dev_err() when handing an
error originating from either platform_get_irq() or
platform_get_irq_byname() function as per suggestion from Coccinelle.

Related commits are commit 7723f4c5ecdb ("driver core: platform: Add an
error message to platform_get_irq*()") and commit 98051ba2b28b
("coccinelle: Add script to check for platform_get_irq() excessive
prints").

Krzysztof Wilczyński (10):
  PCI: dwc: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: mobiveil: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: tegra: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: altera: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: host-generic: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: v3-semi: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: altera-msi: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: xgene-msi: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: rockchip: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: xilinx-nwl: Remove dev_err() when handing an error from
    platform_get_irq()

 drivers/pci/controller/dwc/pci-dra7xx.c              |  8 ++------
 drivers/pci/controller/dwc/pci-exynos.c              |  9 +++------
 drivers/pci/controller/dwc/pci-imx6.c                |  4 +---
 drivers/pci/controller/dwc/pci-keystone.c            |  4 +---
 drivers/pci/controller/dwc/pci-meson.c               |  4 +---
 drivers/pci/controller/dwc/pcie-armada8k.c           |  4 +---
 drivers/pci/controller/dwc/pcie-artpec6.c            |  4 +---
 drivers/pci/controller/dwc/pcie-histb.c              |  4 +---
 drivers/pci/controller/dwc/pcie-kirin.c              |  5 +----
 drivers/pci/controller/dwc/pcie-spear13xx.c          |  5 ++---
 drivers/pci/controller/dwc/pcie-tegra194.c           |  4 +---
 .../pci/controller/mobiveil/pcie-layerscape-gen4.c   |  5 ++---
 drivers/pci/controller/mobiveil/pcie-mobiveil-host.c |  4 +---
 drivers/pci/controller/pci-tegra.c                   |  8 ++------
 drivers/pci/controller/pci-v3-semi.c                 |  5 ++---
 drivers/pci/controller/pci-xgene-msi.c               |  2 --
 drivers/pci/controller/pcie-altera-msi.c             |  1 -
 drivers/pci/controller/pcie-altera.c                 |  4 +---
 drivers/pci/controller/pcie-rockchip-host.c          | 12 +++---------
 drivers/pci/controller/pcie-tango.c                  |  4 +---
 drivers/pci/controller/pcie-xilinx-nwl.c             | 11 ++---------
 21 files changed, 29 insertions(+), 82 deletions(-)

-- 
2.27.0


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2020-08-03 14:55 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 01/10] PCI: dwc: Remove " Krzysztof Wilczyński
2020-08-03  7:16   ` Jesper Nilsson
2020-08-02 14:25 ` [PATCH 02/10] PCI: mobiveil: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 03/10] PCI: tegra: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 04/10] PCI: altera: " Krzysztof Wilczyński
2020-08-03  6:19   ` Tan, Ley Foon
2020-08-02 14:25 ` [PATCH 05/10] PCI: host-generic: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 06/10] PCI: v3-semi: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 07/10] PCI: altera-msi: " Krzysztof Wilczyński
2020-08-02 14:26 ` [PATCH 08/10] PCI: xgene-msi: " Krzysztof Wilczyński
2020-08-02 14:26 ` [PATCH 09/10] PCI: rockchip: " Krzysztof Wilczyński
2020-08-03  2:01 ` [PATCH 00/10] Remove surplus " Bjorn Helgaas
2020-08-03 11:10   ` Krzysztof Wilczyński
2020-08-03 14:55   ` Bjorn Helgaas
2020-08-03  7:10 ` [PATCH 10/10] PCI: xilinx-nwl: Remove " Krzysztof Wilczyński

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).