From: Bjorn Helgaas <helgaas@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
stable <stable@vger.kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Len Brown <lenb@kernel.org>, Jesse Barnes <jsbarnes@google.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Adam Borowski <kilobyte@angband.pl>
Subject: Re: [PATCH v2] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled
Date: Thu, 27 Aug 2020 14:05:17 -0500 [thread overview]
Message-ID: <20200827190517.GA2097725@bjorn-Precision-5520> (raw)
In-Reply-To: <ea903917-e51b-4cc9-2680-bc1e36efa026@infradead.org>
On Fri, Aug 21, 2020 at 05:10:27PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when CONFIG_ACPI is not set/enabled by adding
> the header file <asm/acpi.h> which contains a stub for the function
> in the build error.
>
> ../arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
> ../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
> acpi_noirq_set();
>
> Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: stable@vger.kernel.org # v4.16+
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Len Brown <lenb@kernel.org>
> To: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Barnes <jsbarnes@google.com>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: linux-pci@vger.kernel.org
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reviewed-by: Jesse Barnes <jsbarnes@google.com>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
Applied to pci/misc for v5.10, thanks!
We could put it in v5.9, but a912a7584ec3 was merged for v4.16, so
apparently this has been broken for a long time.
> ---
> Found in linux-next, but applies to/exists in mainline also.
>
> v2:
> - add Reviewed-by: and Acked-by: tags
> - drop alternatives
>
> arch/x86/pci/intel_mid_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200813.orig/arch/x86/pci/intel_mid_pci.c
> +++ linux-next-20200813/arch/x86/pci/intel_mid_pci.c
> @@ -33,6 +33,7 @@
> #include <asm/hw_irq.h>
> #include <asm/io_apic.h>
> #include <asm/intel-mid.h>
> +#include <asm/acpi.h>
>
> #define PCIE_CAP_OFFSET 0x100
>
>
prev parent reply other threads:[~2020-08-27 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 0:10 [PATCH v2] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled Randy Dunlap
2020-08-27 19:05 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827190517.GA2097725@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=arjan@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jsbarnes@google.com \
--cc=kilobyte@angband.pl \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).