From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
You-Sheng Yang <vicamo.yang@canonical.com>
Subject: Re: [PATCH v2] PCI: vmd: Update VMD PM to correctly use generic PCI PM
Date: Mon, 7 Sep 2020 17:59:08 +0100 [thread overview]
Message-ID: <20200907165908.GC10272@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200806210017.5654-1-jonathan.derrick@intel.com>
On Thu, Aug 06, 2020 at 05:00:17PM -0400, Jon Derrick wrote:
> The pci_save_state() call in vmd_suspend() can be performed by
> pci_pm_suspend_irq(). This also allows VMD to benefit from the call into
> pci_prepare_to_sleep().
>
> The pci_restore_state() call in vmd_resume() was restoring state after
> pci_pm_resume()::pci_restore_standard_config() had already restored
> state. It's also been suspected that the config state should have been
> restored before re-requesting IRQs instead of afterwards.
>
> This patch removes the pci_save_state()/pci_restore_state() calls in
> vmd_suspend()/vmd_resume() in order to allow proper flow through generic
> PCI core Power Management code.
>
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Cc: You-Sheng Yang <vicamo.yang@canonical.com>
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> ---
> v1->v2: Commit message cleanup
>
> drivers/pci/controller/vmd.c | 2 --
> 1 file changed, 2 deletions(-)
Applied to pci/vmd, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index 76d8acbee7d5..15c1d85d8780 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -719,7 +719,6 @@ static int vmd_suspend(struct device *dev)
> for (i = 0; i < vmd->msix_count; i++)
> devm_free_irq(dev, pci_irq_vector(pdev, i), &vmd->irqs[i]);
>
> - pci_save_state(pdev);
> return 0;
> }
>
> @@ -737,7 +736,6 @@ static int vmd_resume(struct device *dev)
> return err;
> }
>
> - pci_restore_state(pdev);
> return 0;
> }
> #endif
> --
> 2.18.1
>
prev parent reply other threads:[~2020-09-07 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 21:00 [PATCH v2] PCI: vmd: Update VMD PM to correctly use generic PCI PM Jon Derrick
2020-09-07 16:59 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907165908.GC10272@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-pci@vger.kernel.org \
--cc=vicamo.yang@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).