From: Neil Armstrong <narmstrong@baylibre.com>
To: lorenzo.pieralisi@arm.com, yue.wang@Amlogic.com, robh@kernel.org
Cc: linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout
Date: Mon, 21 Sep 2020 09:49:53 +0200 [thread overview]
Message-ID: <20200921074953.25289-1-narmstrong@baylibre.com> (raw)
When establish link timeouts, probe fails but the error is unrelated since
the PCIe controller has been probed succesfully.
Align with most of the other dw-pcie drivers and ignore return of
dw_pcie_wait_for_link() in the host_init callback.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/pci/controller/dwc/pci-meson.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
index 33deb290c4e7..846275e68fbc 100644
--- a/drivers/pci/controller/dwc/pci-meson.c
+++ b/drivers/pci/controller/dwc/pci-meson.c
@@ -383,10 +383,7 @@ static int meson_pcie_host_init(struct pcie_port *pp)
pp->bridge->ops = &meson_pci_ops;
- ret = meson_pcie_establish_link(mp);
- if (ret)
- return ret;
-
+ meson_pcie_establish_link(mp);
dw_pcie_msi_init(pp);
return 0;
--
2.22.0
next reply other threads:[~2020-09-21 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 7:49 Neil Armstrong [this message]
2020-09-21 15:05 ` Kevin Hilman
2020-09-22 17:30 ` Rob Herring
2020-11-19 11:12 ` Lorenzo Pieralisi
2020-11-19 14:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921074953.25289-1-narmstrong@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=yue.wang@Amlogic.com \
--subject='Re: [PATCH] PCI: dwc/meson: do not fail on wait linkup timeout' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).