From: Frederic Weisbecker <frederic@kernel.org>
To: Nitesh Narayan Lal <nitesh@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
bhelgaas@google.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org,
sassmann@redhat.com, jeffrey.t.kirsher@intel.com,
jacob.e.keller@intel.com, jlelli@redhat.com, hch@infradead.org,
mike.marciniszyn@intel.com, dennis.dalessandro@intel.com,
thomas.lendacky@amd.com, jerinj@marvell.com,
mathias.nyman@intel.com, jiri@nvidia.com
Subject: Re: [RFC][Patch v1 3/3] PCI: Limit pci_alloc_irq_vectors as per housekeeping CPUs
Date: Tue, 22 Sep 2020 23:08:10 +0200 [thread overview]
Message-ID: <20200922210809.GE5217@lenoir> (raw)
In-Reply-To: <75a398cd-2050-e298-d718-eb56d4910133@redhat.com>
On Tue, Sep 22, 2020 at 09:54:58AM -0400, Nitesh Narayan Lal wrote:
> >> If min_vecs > num_housekeeping, for example:
> >>
> >> /* PCI MSI/MSIx support */
> >> #define XGBE_MSI_BASE_COUNT 4
> >> #define XGBE_MSI_MIN_COUNT (XGBE_MSI_BASE_COUNT + 1)
> >>
> >> Then the protection fails.
> > Right, I was ignoring that case.
> >
> >> How about reducing max_vecs down to min_vecs, if min_vecs >
> >> num_housekeeping ?
> > Yes, I think this makes sense.
> > I will wait a bit to see if anyone else has any other comment and will post
> > the next version then.
> >
>
> Are there any other comments/concerns on this patch that I need to address in
> the next posting?
No objection from me, I don't know much about this area anyway.
> --
> Nitesh
>
prev parent reply other threads:[~2020-09-22 21:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 15:08 [RFC] [PATCH v1 0/3] isolation: limit msix vectors based on housekeeping CPUs Nitesh Narayan Lal
2020-09-09 15:08 ` [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs Nitesh Narayan Lal
2020-09-17 18:18 ` Jesse Brandeburg
2020-09-17 18:43 ` Nitesh Narayan Lal
2020-09-17 20:11 ` Bjorn Helgaas
2020-09-17 21:48 ` Jacob Keller
2020-09-17 22:09 ` Nitesh Narayan Lal
2020-09-21 23:40 ` Frederic Weisbecker
2020-09-22 3:16 ` Nitesh Narayan Lal
2020-09-22 10:08 ` Frederic Weisbecker
2020-09-22 13:50 ` Nitesh Narayan Lal
2020-09-22 20:58 ` Frederic Weisbecker
2020-09-22 21:15 ` Nitesh Narayan Lal
2020-09-22 21:26 ` Andrew Lunn
2020-09-22 22:20 ` Nitesh Narayan Lal
2020-09-09 15:08 ` [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs Nitesh Narayan Lal
2020-09-11 15:23 ` Marcelo Tosatti
2020-09-17 18:23 ` Jesse Brandeburg
2020-09-17 18:31 ` Nitesh Narayan Lal
2020-09-21 22:58 ` Frederic Weisbecker
2020-09-22 3:08 ` Nitesh Narayan Lal
2020-09-22 9:54 ` Frederic Weisbecker
2020-09-22 13:34 ` Nitesh Narayan Lal
2020-09-22 20:44 ` Frederic Weisbecker
2020-09-22 21:05 ` Nitesh Narayan Lal
2020-09-09 15:08 ` [RFC][Patch v1 3/3] PCI: Limit pci_alloc_irq_vectors as per " Nitesh Narayan Lal
2020-09-10 19:22 ` Marcelo Tosatti
2020-09-10 19:31 ` Nitesh Narayan Lal
2020-09-22 13:54 ` Nitesh Narayan Lal
2020-09-22 21:08 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922210809.GE5217@lenoir \
--to=frederic@kernel.org \
--cc=bhelgaas@google.com \
--cc=dennis.dalessandro@intel.com \
--cc=hch@infradead.org \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jerinj@marvell.com \
--cc=jiri@nvidia.com \
--cc=jlelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mike.marciniszyn@intel.com \
--cc=mtosatti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nitesh@redhat.com \
--cc=sassmann@redhat.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).