From: Joerg Roedel <joro@8bytes.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Auger Eric <eric.auger@redhat.com>,
iommu@lists.linux-foundation.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, linux-pci@vger.kernel.org,
bhelgaas@google.com, jasowang@redhat.com, kevin.tian@intel.com,
sebastien.boeuf@intel.com, lorenzo.pieralisi@arm.com
Subject: Re: [PATCH v3 0/6] Add virtio-iommu built-in topology
Date: Thu, 24 Sep 2020 13:50:49 +0200 [thread overview]
Message-ID: <20200924115048.GQ27174@8bytes.org> (raw)
In-Reply-To: <20200924102953.GD170808@myrica>
On Thu, Sep 24, 2020 at 12:29:53PM +0200, Jean-Philippe Brucker wrote:
> It's not possible to use exactly the same code for parsing.
The access methods can be separate and don't affect the parsing logic.
> The access methods are different (need to deal with port-IO for
> built-in description on PCI, for example) and more importantly, the
> structure is different as well. The ACPI table needs nodes for
> virtio-iommu while the built-in description is contained in the
> virtio-iommu itself. So the endpoint nodes point to virtio-iommu node
> on ACPI, while they don't need a pointer on the built-in desc. I kept
> as much as possible common in structures and implementation, but in
> the end we still need about 200 unique lines on each side.
Will it hurt the non-ACPI version to have the not-needed pointers anyway
to keep the parsers the same?
Joerg
next prev parent reply other threads:[~2020-09-24 11:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 13:15 [PATCH v3 0/6] Add virtio-iommu built-in topology Jean-Philippe Brucker
2020-08-21 13:15 ` [PATCH v3 1/6] iommu/virtio: Move to drivers/iommu/virtio/ Jean-Philippe Brucker
2020-09-04 15:29 ` Auger Eric
2020-08-21 13:15 ` [PATCH v3 2/6] iommu/virtio: Add topology helpers Jean-Philippe Brucker
2020-09-04 16:22 ` Auger Eric
2020-09-24 8:31 ` Jean-Philippe Brucker
2020-08-21 13:15 ` [PATCH v3 3/6] PCI: Add DMA configuration for virtual platforms Jean-Philippe Brucker
2020-08-21 13:15 ` [PATCH v3 4/6] iommu/virtio: Add topology definitions Jean-Philippe Brucker
2020-09-04 15:30 ` Auger Eric
2020-08-21 13:15 ` [PATCH v3 5/6] iommu/virtio: Support topology description in config space Jean-Philippe Brucker
2020-09-04 16:05 ` Auger Eric
2020-09-24 8:33 ` Jean-Philippe Brucker
2020-09-24 15:22 ` Bjorn Helgaas
2020-09-25 8:12 ` Jean-Philippe Brucker
2020-09-25 15:34 ` Bjorn Helgaas
2020-08-21 13:15 ` [PATCH v3 6/6] iommu/virtio: Enable x86 support Jean-Philippe Brucker
2020-08-26 13:26 ` [PATCH v3 0/6] Add virtio-iommu built-in topology Michael S. Tsirkin
2020-08-27 8:01 ` Jean-Philippe Brucker
2020-09-04 16:24 ` Auger Eric
2020-09-24 9:00 ` Michael S. Tsirkin
2020-09-24 9:21 ` Joerg Roedel
2020-09-24 9:38 ` Michael S. Tsirkin
2020-09-24 9:54 ` Auger Eric
2020-09-29 17:28 ` Al Stone
2020-10-02 18:23 ` Al Stone
2020-10-06 15:23 ` Auger Eric
2020-11-03 20:09 ` Al Stone
2020-11-04 9:33 ` Jean-Philippe Brucker
2020-11-04 20:56 ` Al Stone
2020-09-24 10:02 ` Joerg Roedel
2020-09-24 10:24 ` Gerd Hoffmann
2020-09-24 10:29 ` Jean-Philippe Brucker
2020-09-24 11:50 ` Joerg Roedel [this message]
2020-09-24 12:41 ` Michael S. Tsirkin
2020-09-24 12:50 ` Joerg Roedel
2020-09-25 10:22 ` Michael S. Tsirkin
2020-09-25 8:48 ` Jean-Philippe Brucker
2020-09-25 10:22 ` Michael S. Tsirkin
2020-09-25 11:26 ` Jean-Philippe Brucker
2020-09-25 13:44 ` Michael S. Tsirkin
2020-09-25 14:14 ` [virtio-dev] " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924115048.GQ27174@8bytes.org \
--to=joro@8bytes.org \
--cc=bhelgaas@google.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=kevin.tian@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mst@redhat.com \
--cc=sebastien.boeuf@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).