linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ethan Zhao <haifeng.zhao@intel.com>
To: bhelgaas@google.com, oohall@gmail.com, ruscur@russell.cc,
	lukas@wunner.de, andriy.shevchenko@linux.intel.com,
	stuart.w.hayes@gmail.com, mr.nuke.me@gmail.com,
	mika.westerberg@linux.intel.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	pei.p.jia@intel.com, ashok.raj@linux.intel.com,
	sathyanarayanan.kuppuswamy@intel.com,
	Ethan Zhao <haifeng.zhao@intel.com>
Subject: [PATCH 1/5 V2] PCI: define a function to check and wait till port finish DPC handling
Date: Sat, 26 Sep 2020 23:28:25 -0400	[thread overview]
Message-ID: <20200927032829.11321-2-haifeng.zhao@intel.com> (raw)
In-Reply-To: <20200927032829.11321-1-haifeng.zhao@intel.com>

Once root port DPC capability is enabled and triggered, at the beginning
of DPC is triggered, the DPC status bits are set by hardware and then
sends DPC/DLLSC/PDC interrupts to OS DPC and pciehp drivers, it will
take the port and software DPC interrupt handler 10ms to 50ms (test data
on ICS(Ice Lake SP platform, see
https://en.wikichip.org/wiki/intel/microarchitectures/ice_lake_(server)
& stable 5.9-rc6) to complete the DPC containment procedure
till the DPC status is cleared at the end of the DPC interrupt handler.

We use this function to check if the root port is in DPC handling status
and wait till the hardware and software completed the procedure.

Signed-off-by: Ethan Zhao <haifeng.zhao@intel.com>
Tested-by: Wen Jin <wen.jin@intel.com>
Tested-by: Shanshan Zhang <ShanshanX.Zhang@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
changes:
 V2:align ICS code name to public doc. 
 include/linux/pci.h | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index 835530605c0d..5beb76c6ae26 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -38,6 +38,7 @@
 #include <linux/interrupt.h>
 #include <linux/io.h>
 #include <linux/resource_ext.h>
+#include <linux/delay.h>
 #include <uapi/linux/pci.h>
 
 #include <linux/pci_ids.h>
@@ -2427,4 +2428,34 @@ void pci_uevent_ers(struct pci_dev *pdev, enum  pci_ers_result err_type);
 	WARN_ONCE(condition, "%s %s: " fmt, \
 		  dev_driver_string(&(pdev)->dev), pci_name(pdev), ##arg)
 
+#ifdef CONFIG_PCIE_DPC
+static inline bool pci_wait_port_outdpc(struct pci_dev *pdev)
+{
+	u16 cap = pdev->dpc_cap, status;
+	u16 loop = 0;
+
+	if (!cap) {
+		pci_WARN_ONCE(pdev, !cap, "No DPC capability initiated\n");
+		return false;
+	}
+	pci_read_config_word(pdev, cap + PCI_EXP_DPC_STATUS, &status);
+	pci_dbg(pdev, "DPC status %x, cap %x\n", status, cap);
+	while (status & PCI_EXP_DPC_STATUS_TRIGGER && loop < 100) {
+		msleep(10);
+		loop++;
+		pci_read_config_word(pdev, cap + PCI_EXP_DPC_STATUS, &status);
+	}
+	if (!(status & PCI_EXP_DPC_STATUS_TRIGGER)) {
+		pci_dbg(pdev, "Out of DPC %x, cost %d ms\n", status, loop*10);
+		return true;
+	}
+	pci_dbg(pdev, "Timeout to wait port out of DPC status\n");
+	return false;
+}
+#else
+static inline bool pci_wait_port_outdpc(struct pci_dev *pdev)
+{
+	return true;
+}
+#endif
 #endif /* LINUX_PCI_H */
-- 
2.18.4


  reply	other threads:[~2020-09-27  3:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-27  3:28 [PATCH 0/5 V2] Fix DPC hotplug race and enhance error handling Ethan Zhao
2020-09-27  3:28 ` Ethan Zhao [this message]
2020-09-27  6:23   ` [PATCH 1/5 V2] PCI: define a function to check and wait till port finish DPC handling Christoph Hellwig
2020-09-27  6:43     ` Zhao, Haifeng
2020-09-29  2:32     ` Ethan Zhao
2020-09-27  3:28 ` [PATCH 2/5 V2] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC Ethan Zhao
2020-09-27 15:27   ` Sinan Kaya
2020-09-28  2:01     ` Zhao, Haifeng
2020-09-28 11:10       ` Sinan Kaya
2020-09-28 16:43         ` Sinan Kaya
2020-09-28 16:44           ` Kuppuswamy, Sathyanarayanan
2020-09-29  2:28             ` Ethan Zhao
2020-09-29  2:50           ` Ethan Zhao
2020-09-29  8:18     ` Lukas Wunner
2020-09-29  9:46       ` Ethan Zhao
2020-09-29 10:07         ` Lukas Wunner
2020-09-30  2:20           ` Ethan Zhao
2020-09-27  3:28 ` [PATCH 3/5 V2] PCI/ERR: get device before call device driver to avoid NULL pointer reference Ethan Zhao
2020-09-27  3:28 ` [PATCH 4/5 V2] PCI: only return true when dev io state is really changed Ethan Zhao
2020-09-27  4:16   ` Joe Perches
2020-09-27  5:12     ` Zhao, Haifeng
2020-09-27  3:28 ` [PATCH 5/5 V2] PCI/ERR: don't mix io state not changed and no driver together Ethan Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200927032829.11321-2-haifeng.zhao@intel.com \
    --to=haifeng.zhao@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ashok.raj@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mr.nuke.me@gmail.com \
    --cc=oohall@gmail.com \
    --cc=pei.p.jia@intel.com \
    --cc=ruscur@russell.cc \
    --cc=sathyanarayanan.kuppuswamy@intel.com \
    --cc=stuart.w.hayes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).