From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] PCI: tegra: convert to use DEFINE_SEQ_ATTRIBUTE macro
Date: Mon, 28 Sep 2020 12:09:57 +0100 [thread overview]
Message-ID: <20200928110957.GA13256@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200916025025.3992783-1-liushixin2@huawei.com>
On Wed, Sep 16, 2020 at 10:50:25AM +0800, Liu Shixin wrote:
> Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> drivers/pci/controller/pci-tegra.c | 28 +++-------------------------
> 1 file changed, 3 insertions(+), 25 deletions(-)
Applied to pci/tegra, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index c1d34353c29b..556c30a718f0 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2564,36 +2564,14 @@ static int tegra_pcie_ports_seq_show(struct seq_file *s, void *v)
> return 0;
> }
>
> -static const struct seq_operations tegra_pcie_ports_seq_ops = {
> +static const struct seq_operations tegra_pcie_ports_sops = {
> .start = tegra_pcie_ports_seq_start,
> .next = tegra_pcie_ports_seq_next,
> .stop = tegra_pcie_ports_seq_stop,
> .show = tegra_pcie_ports_seq_show,
> };
>
> -static int tegra_pcie_ports_open(struct inode *inode, struct file *file)
> -{
> - struct tegra_pcie *pcie = inode->i_private;
> - struct seq_file *s;
> - int err;
> -
> - err = seq_open(file, &tegra_pcie_ports_seq_ops);
> - if (err)
> - return err;
> -
> - s = file->private_data;
> - s->private = pcie;
> -
> - return 0;
> -}
> -
> -static const struct file_operations tegra_pcie_ports_ops = {
> - .owner = THIS_MODULE,
> - .open = tegra_pcie_ports_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = seq_release,
> -};
> +DEFINE_SEQ_ATTRIBUTE(tegra_pcie_ports);
>
> static void tegra_pcie_debugfs_exit(struct tegra_pcie *pcie)
> {
> @@ -2610,7 +2588,7 @@ static int tegra_pcie_debugfs_init(struct tegra_pcie *pcie)
> return -ENOMEM;
>
> file = debugfs_create_file("ports", S_IFREG | S_IRUGO, pcie->debugfs,
> - pcie, &tegra_pcie_ports_ops);
> + pcie, &tegra_pcie_ports_fops);
> if (!file)
> goto remove;
>
> --
> 2.25.1
>
prev parent reply other threads:[~2020-09-28 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 2:50 [PATCH -next] PCI: tegra: convert to use DEFINE_SEQ_ATTRIBUTE macro Liu Shixin
2020-09-17 11:01 ` Thierry Reding
2020-09-28 11:09 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928110957.GA13256@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).