From: "Raj, Ashok" <ashok.raj@intel.com>
To: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Cc: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@intel.com>,
linux-kernel@vger.kernel.org, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH 1/1] pci: pciehp: Handle MRL interrupts to enable slot for hotplug.
Date: Fri, 16 Oct 2020 16:43:33 -0700 [thread overview]
Message-ID: <20201016234333.GB103781@otc-nc-03> (raw)
In-Reply-To: <20200925230138.29011-1-ashok.raj@intel.com>
Hi Bjorn
On Fri, Sep 25, 2020 at 04:01:38PM -0700, Ashok Raj wrote:
> When Mechanical Retention Lock (MRL) is present, Linux doesn't process
> those change events.
>
> The following changes need to be enabled when MRL is present.
>
> 1. Subscribe to MRL change events in SlotControl.
> 2. When MRL is closed,
> - If there is no ATTN button, then POWER on the slot.
> - If there is ATTN button, and an MRL event pending, ignore
> Presence Detect. Since we want ATTN button to drive the
> hotplug event.
>
Did you get a chance to review this? Thought i'll just check with you.
Seems like there was a lot happening in the error handling and hotplug
side, I thought you might have wanted to wait for the dust to settle :-)
>
> Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> Co-developed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> ---
> drivers/pci/hotplug/pciehp.h | 1 +
> drivers/pci/hotplug/pciehp_ctrl.c | 69 +++++++++++++++++++++++++++++++++++++++
> drivers/pci/hotplug/pciehp_hpc.c | 27 ++++++++++++++-
> 3 files changed, 96 insertions(+), 1 deletion(-)
>
next prev parent reply other threads:[~2020-10-16 23:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 23:01 [PATCH 1/1] pci: pciehp: Handle MRL interrupts to enable slot for hotplug Ashok Raj
2020-10-16 23:43 ` Raj, Ashok [this message]
2020-11-19 7:51 ` Lukas Wunner
2020-11-19 22:08 ` Raj, Ashok
2020-11-19 22:27 ` Bjorn Helgaas
2020-11-19 22:37 ` Raj, Ashok
2020-11-20 19:33 ` Kuppuswamy, Sathyanarayanan
2020-11-21 11:10 ` Lukas Wunner
2020-11-22 1:31 ` Raj, Ashok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016234333.GB103781@otc-nc-03 \
--to=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).