linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pci: remove unneeded break
@ 2020-10-19 19:02 trix
  2020-10-20 13:23 ` Linus Walleij
  2020-10-20 16:02 ` Bjorn Helgaas
  0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2020-10-19 19:02 UTC (permalink / raw)
  To: linus.walleij, lorenzo.pieralisi, robh, bhelgaas
  Cc: linux-pci, linux-kernel, Tom Rix

From: Tom Rix <trix@redhat.com>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/pci/controller/pci-v3-semi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
index 1f54334f09f7..154a5398633c 100644
--- a/drivers/pci/controller/pci-v3-semi.c
+++ b/drivers/pci/controller/pci-v3-semi.c
@@ -658,7 +658,6 @@ static int v3_get_dma_range_config(struct v3_pci *v3,
 	default:
 		dev_err(v3->dev, "illegal dma memory chunk size\n");
 		return -EINVAL;
-		break;
 	}
 	val |= V3_PCI_MAP_M_REG_EN | V3_PCI_MAP_M_ENABLE;
 	*pci_map = val;
-- 
2.18.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pci: remove unneeded break
  2020-10-19 19:02 [PATCH] pci: remove unneeded break trix
@ 2020-10-20 13:23 ` Linus Walleij
  2020-10-20 16:02 ` Bjorn Helgaas
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-10-20 13:23 UTC (permalink / raw)
  To: trix
  Cc: Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas, linux-pci, linux-kernel

On Mon, Oct 19, 2020 at 9:03 PM <trix@redhat.com> wrote:

> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pci: remove unneeded break
  2020-10-19 19:02 [PATCH] pci: remove unneeded break trix
  2020-10-20 13:23 ` Linus Walleij
@ 2020-10-20 16:02 ` Bjorn Helgaas
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2020-10-20 16:02 UTC (permalink / raw)
  To: trix
  Cc: linus.walleij, lorenzo.pieralisi, robh, bhelgaas, linux-pci,
	linux-kernel

On Mon, Oct 19, 2020 at 12:02:49PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> A break is not needed if it is preceded by a return
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied with Linus' reviewed-by to pci/misc for v5.10, thanks!

> ---
>  drivers/pci/controller/pci-v3-semi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
> index 1f54334f09f7..154a5398633c 100644
> --- a/drivers/pci/controller/pci-v3-semi.c
> +++ b/drivers/pci/controller/pci-v3-semi.c
> @@ -658,7 +658,6 @@ static int v3_get_dma_range_config(struct v3_pci *v3,
>  	default:
>  		dev_err(v3->dev, "illegal dma memory chunk size\n");
>  		return -EINVAL;
> -		break;
>  	}
>  	val |= V3_PCI_MAP_M_REG_EN | V3_PCI_MAP_M_ENABLE;
>  	*pci_map = val;
> -- 
> 2.18.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-20 16:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 19:02 [PATCH] pci: remove unneeded break trix
2020-10-20 13:23 ` Linus Walleij
2020-10-20 16:02 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).