From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F0CC4363A for ; Tue, 20 Oct 2020 15:20:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47E0E2222D for ; Tue, 20 Oct 2020 15:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603207209; bh=yxjZLTL9G0GiWhcCxam1MP9Mr+loAoklnAmAo3SCEj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=G/xEIEdo7dFP11H3S2APHN4XBQ/2aHQYfNPxWdsrT8OfXIGxQATzCWLlRNfrieUJz SoJ3DytA0VLnjdSWCko9/qNGj4yDES8GC15NWDW1zT3AeJHkrQT5W7JjbMG8fdeeHD H/uvwzI9TklanWvs4RlOb6mVXWRvcH54viZ4EcE8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408647AbgJTPUI (ORCPT ); Tue, 20 Oct 2020 11:20:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:42864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408646AbgJTPUI (ORCPT ); Tue, 20 Oct 2020 11:20:08 -0400 Received: from dhcp-10-100-145-180.wdc.com (unknown [199.255.45.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F52420757; Tue, 20 Oct 2020 15:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603207208; bh=yxjZLTL9G0GiWhcCxam1MP9Mr+loAoklnAmAo3SCEj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G9+59JztDbdsj4eCvFkRhf0Mg5w6NuvCUjVykcs2EzrCyONDCIAvL9wZWI/Gawn0g seMiadmLoIbxzxS0S47/0lQNq1SX4pDlcyG64pWPlT3SzIEC67lkA4jxC8qw/nYOgF 5+4p3D1ba98725eJrWr9cP5SoKDpFf2WGfakP4b0= Date: Tue, 20 Oct 2020 08:20:05 -0700 From: Keith Busch To: Jian-Hong Pan Cc: Jon Derrick , Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, You-Sheng Yang , linux@endlessm.com Subject: Re: [PATCH] PCI: vmd: Add AHCI to fast interrupt list Message-ID: <20201020152005.GA1437971@dhcp-10-100-145-180.wdc.com> References: <20200904171325.64959-1-jonathan.derrick@intel.com> <20201019093734.4091-1-jhp@endlessos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201019093734.4091-1-jhp@endlessos.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Oct 19, 2020 at 05:37:35PM +0800, Jian-Hong Pan wrote: > >On 2020-09-05 01:13, Jon Derrick wrote: > >> Some platforms have an AHCI controller behind VMD. These platforms are > >> working correctly except for a case when the AHCI MSI is programmed with > >> VMD IRQ vector 0 (0xfee00000). When programmed with any other interrupt > >> (0xfeeNN000), the MSI is routed correctly and is handled by VMD. Placing > >> the AHCI MSI(s) in the fast-interrupt allow list solves the issue. > >> > >> This also requires that VMD allocate more than one MSI/X vector and > >> changes the minimum MSI/X vectors allocated to two. > >> > >> Signed-off-by: Jon Derrick > > > > Verified two platforms with such configuration. Thank you. > > > > You-Sheng Yang > > We have some laptops equipped with Tiger Lake chips and such configuration that > hit the same issue, too. They all could be fixed by this patch. Thank you > > Tested-by: Jian-Hong Pan Please use the v3 instead: https://patchwork.kernel.org/project/linux-pci/patch/20200914190128.5114-1-jonathan.derrick@intel.com/ I'm not sure if there's anything remaining that's gating inclusion, though.