From: Sherry Sun <sherry.sun@nxp.com> To: hch@infradead.org, sudeep.dutt@intel.com, ashutosh.dixit@intel.com, arnd@arndb.de, gregkh@linuxfoundation.org, kishon@ti.com, lorenzo.pieralisi@arm.com Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH V3 0/4] Change vring space from nomal memory to dma coherent memory Date: Thu, 22 Oct 2020 13:06:34 +0800 [thread overview] Message-ID: <20201022050638.29641-1-sherry.sun@nxp.com> (raw) Changes in V3: 1. Change the device page allocation method of the Intel mic layer in Patch 1 to align with the vring allocation. 2. Move the vring physical address changes in mmap callback from Prach 3 to 1. 3. Use must_be_zero instead of directly deleting used_address_updated in Patch 2 to avoid the influence of ABI change. (I tried to use dma_mmap_coherent api in Patch 4 as Christoph suggested, but met some issues explained here https://lore.kernel.org/patchwork/patch/1313327/, so there is no change to Patch 4, and still can't find a better way than patch 3) The original vop driver only supports dma coherent device, as it allocates and maps vring by _get_free_pages and dma_map_single, but not use dma_sync_single_for_cpu/device to sync the updates of device_page/vring between EP and RC, which will cause memory synchronization problem for device don't support hardware dma coherent. And allocate vrings use dma_alloc_coherent is a common way in kernel, as the memory interacted between two systems should use consistent memory to avoid caching effects. So here add noncoherent platform support for vop driver. Also add some related dma changes to make sure noncoherent platform works well. Sherry Sun (4): misc: vop: change the way of allocating vring and device page misc: vop: do not allocate and reassign the used ring misc: vop: simply return the saved dma address instead of virt_to_phys misc: vop: mapping kernel memory to user space as noncached drivers/misc/mic/bus/vop_bus.h | 2 + drivers/misc/mic/host/mic_boot.c | 8 +++ drivers/misc/mic/host/mic_main.c | 15 ++---- drivers/misc/mic/vop/vop_debugfs.c | 2 - drivers/misc/mic/vop/vop_main.c | 48 +++-------------- drivers/misc/mic/vop/vop_vringh.c | 84 +++++++----------------------- include/uapi/linux/mic_common.h | 5 +- 7 files changed, 42 insertions(+), 122 deletions(-) -- 2.17.1
next reply other threads:[~2020-10-22 5:07 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-22 5:06 Sherry Sun [this message] 2020-10-22 5:06 ` [PATCH V3 1/4] misc: vop: change the way of allocating vring and device page Sherry Sun 2020-10-22 7:58 ` kernel test robot 2020-10-23 9:25 ` Christoph Hellwig 2020-10-26 2:54 ` Sherry Sun 2020-10-22 5:06 ` [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring Sherry Sun 2020-10-22 8:53 ` kernel test robot 2020-10-23 9:26 ` Christoph Hellwig 2020-10-26 3:04 ` Sherry Sun 2020-10-27 6:28 ` gregkh 2020-10-22 5:06 ` [PATCH V3 3/4] misc: vop: simply return the saved dma address instead of virt_to_phys Sherry Sun 2020-10-22 5:06 ` [PATCH V3 4/4] misc: vop: mapping kernel memory to user space as noncached Sherry Sun 2020-10-23 9:28 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201022050638.29641-1-sherry.sun@nxp.com \ --to=sherry.sun@nxp.com \ --cc=arnd@arndb.de \ --cc=ashutosh.dixit@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=hch@infradead.org \ --cc=kishon@ti.com \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=sudeep.dutt@intel.com \ --subject='Re: [PATCH V3 0/4] Change vring space from nomal memory to dma coherent memory' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).