linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	bhelgaas@google.com
Subject: Re: [PATCH 1/2] PCI: export pci_match_device()
Date: Thu, 22 Oct 2020 16:21:48 +0100	[thread overview]
Message-ID: <20201022152148.GA23673@infradead.org> (raw)
In-Reply-To: <20201021081030.160-1-zhenzhong.duan@gmail.com>

On Wed, Oct 21, 2020 at 04:10:29PM +0800, Zhenzhong Duan wrote:
> pci_match_id() is deprecated as it doesn't catch any dynamic ids that
> a driver might want to check for.
> 
> Export pci_match_device() as a replacement which supports both dynamic
> and static ids.

You don't actually seems to add any user outside of the PCI core,
so I think you only need to drop the static specifier and add a
prototype.

  parent reply	other threads:[~2020-10-22 15:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21  8:10 [PATCH 1/2] PCI: export pci_match_device() Zhenzhong Duan
2020-10-21  8:10 ` [PATCH 2/2] PCI: add support for dynamic ID when checking for duplicate IDs Zhenzhong Duan
2020-10-22 15:21 ` Christoph Hellwig [this message]
2020-10-26  2:52   ` [PATCH 1/2] PCI: export pci_match_device() Zhenzhong Duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201022152148.GA23673@infradead.org \
    --to=hch@infradead.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=zhenzhong.duan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).