From: kernel test robot <lkp@intel.com> To: Sherry Sun <sherry.sun@nxp.com>, hch@infradead.org, sudeep.dutt@intel.com, ashutosh.dixit@intel.com, arnd@arndb.de, gregkh@linuxfoundation.org, kishon@ti.com, lorenzo.pieralisi@arm.com Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH V3 1/4] misc: vop: change the way of allocating vring and device page Date: Thu, 22 Oct 2020 15:58:47 +0800 [thread overview] Message-ID: <202010221544.y0VPwYec-lkp@intel.com> (raw) In-Reply-To: <20201022050638.29641-2-sherry.sun@nxp.com> [-- Attachment #1: Type: text/plain, Size: 3037 bytes --] Hi Sherry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on soc/for-next linus/master v5.9 next-20201022] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sherry-Sun/Change-vring-space-from-nomal-memory-to-dma-coherent-memory/20201022-131008 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git f3277cbfba763cd2826396521b9296de67cf1bbc config: i386-randconfig-s002-20201022 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-dirty # https://github.com/0day-ci/linux/commit/6851e84ec2f16ab12b04b2a5bf61b05465d450e6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sherry-Sun/Change-vring-space-from-nomal-memory-to-dma-coherent-memory/20201022-131008 git checkout 6851e84ec2f16ab12b04b2a5bf61b05465d450e6 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> "sparse warnings: (new ones prefixed by >>)" >> drivers/misc/mic/vop/vop_vringh.c:1052:29: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long @@ got restricted __le64 [usertype] address @@ >> drivers/misc/mic/vop/vop_vringh.c:1052:29: sparse: expected unsigned long >> drivers/misc/mic/vop/vop_vringh.c:1052:29: sparse: got restricted __le64 [usertype] address vim +1052 drivers/misc/mic/vop/vop_vringh.c 1024 1025 static inline int 1026 vop_query_offset(struct vop_vdev *vdev, unsigned long offset, 1027 unsigned long *size, unsigned long *pa) 1028 { 1029 struct vop_device *vpdev = vdev->vpdev; 1030 struct mic_vqconfig *vqconfig = mic_vq_config(vdev->dd); 1031 unsigned long start = MIC_DP_SIZE; 1032 int i; 1033 1034 /* 1035 * MMAP interface is as follows: 1036 * offset region 1037 * 0x0 virtio device_page 1038 * 0x1000 first vring 1039 * 0x1000 + size of 1st vring second vring 1040 * .... 1041 */ 1042 if (!offset) { 1043 *pa = virt_to_phys(vpdev->hw_ops->get_dp(vpdev)); 1044 *size = MIC_DP_SIZE; 1045 return 0; 1046 } 1047 1048 for (i = 0; i < vdev->dd->num_vq; i++) { 1049 struct vop_vringh *vvr = &vdev->vvr[i]; 1050 1051 if (offset == start) { > 1052 *pa = vqconfig[i].address; 1053 *size = vvr->vring.len; 1054 return 0; 1055 } 1056 start += vvr->vring.len; 1057 } 1058 return -1; 1059 } 1060 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 36245 bytes --]
next prev parent reply other threads:[~2020-10-22 7:59 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-22 5:06 [PATCH V3 0/4] Change vring space from nomal memory to dma coherent memory Sherry Sun 2020-10-22 5:06 ` [PATCH V3 1/4] misc: vop: change the way of allocating vring and device page Sherry Sun 2020-10-22 7:58 ` kernel test robot [this message] 2020-10-23 9:25 ` Christoph Hellwig 2020-10-26 2:54 ` Sherry Sun 2020-10-22 5:06 ` [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring Sherry Sun 2020-10-22 8:53 ` kernel test robot 2020-10-23 9:26 ` Christoph Hellwig 2020-10-26 3:04 ` Sherry Sun 2020-10-27 6:28 ` gregkh 2020-10-22 5:06 ` [PATCH V3 3/4] misc: vop: simply return the saved dma address instead of virt_to_phys Sherry Sun 2020-10-22 5:06 ` [PATCH V3 4/4] misc: vop: mapping kernel memory to user space as noncached Sherry Sun 2020-10-23 9:28 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202010221544.y0VPwYec-lkp@intel.com \ --to=lkp@intel.com \ --cc=arnd@arndb.de \ --cc=ashutosh.dixit@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=hch@infradead.org \ --cc=kbuild-all@lists.01.org \ --cc=kishon@ti.com \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=sherry.sun@nxp.com \ --cc=sudeep.dutt@intel.com \ --subject='Re: [PATCH V3 1/4] misc: vop: change the way of allocating vring and device page' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).