From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AFB8C388F9 for ; Thu, 22 Oct 2020 21:32:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A02024630 for ; Thu, 22 Oct 2020 21:32:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="R5E79aKe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2898678AbgJVVcv (ORCPT ); Thu, 22 Oct 2020 17:32:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2898656AbgJVVcv (ORCPT ); Thu, 22 Oct 2020 17:32:51 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1190FC0613CE for ; Thu, 22 Oct 2020 14:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JiUgbggdsaH0fAvaE5gc+q5S/d6utXLSeDGH01+onrs=; b=R5E79aKeJmzoTpbPDo4GXnJVq 22BIEzNCZHek0kMrh5qVE+2Cb7nQz8JhVkK6PEfotlkxtbLGVpXAPjvgtJKAYhp14Djh7EuVDNhY3 VPZ4fb4CRnHQxCez7AlGK3kbk+T2qZf8fHksGdyLH8p7GkPUO9qWwmxR0bIBv7HFs8OqrQ/UCUtqE k+jQEPN8HsRQMdDFK8asFdnQS8luVqQie93Et79y6xOlA9oU8JAoWUqYU0/ev+/15Us3pfWW6ruY8 WVGeacP0v3BPMjFmXpo1jdAwqPSOF51sZXkcFVHkXMj0JstOHXcFsOXrdbAABfa0cMvbBjNLtvdjB jQhztbY8Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49686) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kViCU-0002bE-Hq; Thu, 22 Oct 2020 22:32:46 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kViCU-0007kN-4q; Thu, 22 Oct 2020 22:32:46 +0100 Date: Thu, 22 Oct 2020 22:32:46 +0100 From: Russell King - ARM Linux admin To: Rob Herring , Lorenzo Pieralisi , Thomas Petazzoni , Jason Cooper Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [BUG] PCIe on Armada 388 broken since 5.9 Message-ID: <20201022213246.GV1551@shell.armlinux.org.uk> References: <20201022211821.GU1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201022211821.GU1551@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Oct 22, 2020 at 10:18:21PM +0100, Russell King - ARM Linux admin wrote: > Hi, > > It appears that PCIe on Armada 388 has been broken in 5.9. Here are > the boot messages: > > mvebu-pcie soc:pcie: host bridge /soc/pcie ranges: > mvebu-pcie soc:pcie: MEM 0x00f1080000..0x00f1081fff -> 0x0000080000 > mvebu-pcie soc:pcie: MEM 0x00f1040000..0x00f1041fff -> 0x0000040000 > mvebu-pcie soc:pcie: MEM 0x00f1044000..0x00f1045fff -> 0x0000044000 > mvebu-pcie soc:pcie: MEM 0x00f1048000..0x00f1049fff -> 0x0000048000 > mvebu-pcie soc:pcie: MEM 0xffffffffffffffff..0x00fffffffe -> 0x0100000000 > mvebu-pcie soc:pcie: IO 0xffffffffffffffff..0x00fffffffe -> 0x0100000000 > mvebu-pcie soc:pcie: MEM 0xffffffffffffffff..0x00fffffffe -> 0x0200000000 > mvebu-pcie soc:pcie: IO 0xffffffffffffffff..0x00fffffffe -> 0x0200000000 > mvebu-pcie soc:pcie: MEM 0xffffffffffffffff..0x00fffffffe -> 0x0300000000 > mvebu-pcie soc:pcie: IO 0xffffffffffffffff..0x00fffffffe -> 0x0300000000 > mvebu-pcie soc:pcie: MEM 0xffffffffffffffff..0x00fffffffe -> 0x0400000000 > mvebu-pcie soc:pcie: IO 0xffffffffffffffff..0x00fffffffe -> 0x0400000000 > mvebu-pcie soc:pcie: resource collision: [mem 0xf1080000-0xf1081fff] conflicts with pcie [mem 0xf1080000-0xf1081fff] > mvebu-pcie: probe of soc:pcie failed with error -16 > > This results in PCIe being entirely non-functional. At a guess, I'd > say it's due to: > > commit c322fa0b3fa948010a278794e60c45ec860e4a1e > Author: Rob Herring > Date: Fri May 22 17:48:19 2020 -0600 > > PCI: mvebu: Use struct pci_host_bridge.windows list directly > > There's no need to create a temporary resource list and then splice it to > struct pci_host_bridge.windows list. Just use pci_host_bridge.windows > directly. The necessary clean-up is already handled by the PCI core. > > Link: https://lore.kernel.org/r/20200522234832.954484-3-robh@kernel.org > Signed-off-by: Rob Herring > Signed-off-by: Lorenzo Pieralisi > Cc: Thomas Petazzoni > Cc: Jason Cooper Confirmed. Reverting this commit results in functioning PCIe. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!