linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	Paul Burton <paulburton@kernel.org>,
	linux-mips@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: export pci_find_host_bridge() to fix MFD build error
Date: Fri, 23 Oct 2020 07:47:40 +0100	[thread overview]
Message-ID: <20201023064740.GB22405@infradead.org> (raw)
In-Reply-To: <20201021100844.GA3693@alpha.franken.de>

On Wed, Oct 21, 2020 at 12:08:45PM +0200, Thomas Bogendoerfer wrote:
> On Tue, Oct 20, 2020 at 09:02:19AM +0100, Christoph Hellwig wrote:
> > On Sun, Oct 18, 2020 at 11:14:53PM -0700, Randy Dunlap wrote:
> > > Fix a build error in drivers/mfd/ioc.o by exporting
> > > pci_find_host_bridge().
> > > 
> > > ERROR: modpost: "pci_find_host_bridge" [drivers/mfd/ioc3.ko] undefined!
> > 
> > I think the mfd code should be fixed to not depend on such an internal
> > symbol instead.
> 
> are you talking about the EXPORT_SYMBOL or the usage of
> pci_find_host_bridge() outside of drivers/pci ? If the latter the
> function is used in arm/arm64 code and pci controller code... so
> I doesn't look like a pure internal symbol to me.

All of those are built-in and related bits aren't exported at all, or
at best EXPORT_SYMBOL_GPL.  I think just not allowing the ioc3 mfd to
be built modular might be the easiest fix here.  Especially as for IP27
and co kernel it is everything but optional anyway.

      reply	other threads:[~2020-10-23  6:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19  6:14 Randy Dunlap
2020-10-20  8:02 ` Christoph Hellwig
2020-10-20 14:06   ` Randy Dunlap
2020-10-20 15:51     ` Randy Dunlap
2020-10-20 16:04       ` Randy Dunlap
2020-10-21 10:08   ` Thomas Bogendoerfer
2020-10-23  6:47     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201023064740.GB22405@infradead.org \
    --to=hch@infradead.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=paulburton@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=tsbogend@alpha.franken.de \
    --subject='Re: [PATCH] PCI: export pci_find_host_bridge() to fix MFD build error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).