Linux-PCI Archive on
 help / color / Atom feed
From: Christoph Hellwig <>
To: Zhenzhong Duan <>
Subject: Re: [PATCH v2] PCI: check also dynamic IDs for duplicate in new_id_store()
Date: Tue, 27 Oct 2020 07:52:17 +0000
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Oct 26, 2020 at 11:57:10AM +0800, Zhenzhong Duan wrote:
> When a device ID data is writen to /sys/bus/pci/drivers/.../new_id,
> only static ID table is checked for duplicate and multiple dynamic ID
> entries of same kind are allowed to exist in a dynamic linked list.
> Fix it by calling pci_match_device() which checks both dynamic and static
> IDs.
> After fix, it shows below result which is expected.
> echo "1af4:1000" > /sys/bus/pci/drivers/vfio-pci/new_id
> echo "1af4:1000" > /sys/bus/pci/drivers/vfio-pci/new_id
> -bash: echo: write error: File exists
> Drop the static specifier and add a prototype to avoid build error.
> Signed-off-by: Zhenzhong Duan <>

Looks good,

Reviewed-by: Christoph Hellwig <>

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26  3:57 Zhenzhong Duan
2020-10-27  7:52 ` Christoph Hellwig [this message]
2020-11-10 12:36   ` Zhenzhong Duan
2020-11-13 22:47 ` Bjorn Helgaas
2020-11-16  7:08   ` Zhenzhong Duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on

Archives are clonable:
	git clone --mirror linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ \
	public-inbox-index linux-pci

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone