From: Christoph Hellwig <hch@infradead.org>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
bhelgaas@google.com, hch@infradead.org
Subject: Re: [PATCH v2] PCI: check also dynamic IDs for duplicate in new_id_store()
Date: Tue, 27 Oct 2020 07:52:17 +0000 [thread overview]
Message-ID: <20201027075217.GA30879@infradead.org> (raw)
In-Reply-To: <20201026035710.593-1-zhenzhong.duan@gmail.com>
On Mon, Oct 26, 2020 at 11:57:10AM +0800, Zhenzhong Duan wrote:
> When a device ID data is writen to /sys/bus/pci/drivers/.../new_id,
> only static ID table is checked for duplicate and multiple dynamic ID
> entries of same kind are allowed to exist in a dynamic linked list.
>
> Fix it by calling pci_match_device() which checks both dynamic and static
> IDs.
>
> After fix, it shows below result which is expected.
>
> echo "1af4:1000" > /sys/bus/pci/drivers/vfio-pci/new_id
> echo "1af4:1000" > /sys/bus/pci/drivers/vfio-pci/new_id
> -bash: echo: write error: File exists
>
> Drop the static specifier and add a prototype to avoid build error.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-10-27 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 3:57 [PATCH v2] PCI: check also dynamic IDs for duplicate in new_id_store() Zhenzhong Duan
2020-10-27 7:52 ` Christoph Hellwig [this message]
2020-11-10 12:36 ` Zhenzhong Duan
2020-11-13 22:47 ` Bjorn Helgaas
2020-11-16 7:08 ` Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027075217.GA30879@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=zhenzhong.duan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).