From: Zhang Qilong <zhangqilong3@huawei.com>
To: <lorenzo.pieralisi@arm.com>, <robh@kernel.org>,
<bhelgaas@google.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>
Cc: <linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>
Subject: [PATCH] PCI: dwc: fix reference leak in pex_ep_event_pex_rst_deassert
Date: Mon, 2 Nov 2020 22:30:45 +0800 [thread overview]
Message-ID: <20201102143045.142121-1-zhangqilong3@huawei.com> (raw)
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in pex_ep_event_pex_rst_deassert, so we should
fix it.
Fixes: c57247f940e8e ("PCI: tegra: Add support for PCIe endpoint mode in Tegra194")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index f920e7efe118..936510b5c649 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -1662,6 +1662,7 @@ static void pex_ep_event_pex_rst_deassert(struct tegra_pcie_dw *pcie)
ret = pm_runtime_get_sync(dev);
if (ret < 0) {
+ pm_runtime_put_noidle(dev);
dev_err(dev, "Failed to get runtime sync for PCIe dev: %d\n",
ret);
return;
--
2.17.1
next reply other threads:[~2020-11-02 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 14:30 Zhang Qilong [this message]
2020-11-03 2:52 ` [PATCH] PCI: dwc: fix reference leak in pex_ep_event_pex_rst_deassert Vidya Sagar
2020-11-03 3:14 ` 答复: " zhangqilong
2021-01-25 16:34 ` Lorenzo Pieralisi
2021-01-27 6:19 ` Vidya Sagar
2021-01-25 19:30 ` Jon Hunter
2021-03-23 10:24 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102143045.142121-1-zhangqilong3@huawei.com \
--to=zhangqilong3@huawei.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).