From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 845A6C388F9 for ; Wed, 11 Nov 2020 07:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25CAC207D3 for ; Wed, 11 Nov 2020 07:22:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ly/FwRGB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726097AbgKKHWP (ORCPT ); Wed, 11 Nov 2020 02:22:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbgKKHMd (ORCPT ); Wed, 11 Nov 2020 02:12:33 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E21E5C0613D4; Tue, 10 Nov 2020 23:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9NVZFoWOtk2drwb+CBbjE6+h56gdwxT/Zba1uNpXaGw=; b=Ly/FwRGB6s17s+VOTeDWLpa5bI U/tAKGAsqHG29rGnzgsx9kRnnJB0ESyPoLkqB0N8gAjBawjuZ43jgi/VK/qA6iJLtj/uI6xpjQ9U5 DMvKqgOiJaUnq2uvDQZzipHzHChurgPWtFZr25G8ApM9zr697X/1b53eDLKCOi5pcF1rY9weOlqxT SSnl3SxN2KNn40M027o30R6h6z19/TtKqgKxI8PIxp1NW/cvjjHlNuHnX712+AoZZupp8+WR0h+pk xRnd1ydcUZ50imKbLNBX/wmuUQhPIvXAI31LLyGLzplFwxT0yCtWMLcxzCfVc0WJiWTKzL1L3Y0uK fPOJ8+tA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kckIx-0002qG-Cf; Wed, 11 Nov 2020 07:12:31 +0000 Date: Wed, 11 Nov 2020 07:12:31 +0000 From: Christoph Hellwig To: Ben Widawsky Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Dan Williams , Ira Weiny , Vishal Verma , "Kelley, Sean V" , Bjorn Helgaas , "Rafael J . Wysocki" Subject: Re: [RFC PATCH 3/9] cxl/mem: Add a driver for the type-3 mailbox Message-ID: <20201111071231.GC7829@infradead.org> References: <20201111054356.793390-1-ben.widawsky@intel.com> <20201111054356.793390-4-ben.widawsky@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111054356.793390-4-ben.widawsky@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Nov 10, 2020 at 09:43:50PM -0800, Ben Widawsky wrote: > +config CXL_MEM > + tristate "CXL.mem Device Support" > + depends on PCI && CXL_BUS_PROVIDER != n depend on PCI && CXL_BUS_PROVIDER > + default m if CXL_BUS_PROVIDER Please don't set weird defaults for new code. Especially not default to module crap like this. > +// Copyright(c) 2020 Intel Corporation. All rights reserved. Please don't use '//' for anything but the SPDX header. > + > + pci_read_config_word(pdev, pos + PCI_DVSEC_VENDOR_OFFSET, &vendor); > + pci_read_config_word(pdev, pos + PCI_DVSEC_ID_OFFSET, &id); > + if (vendor == PCI_DVSEC_VENDOR_CXL && dvsec == id) > + return pos; > + > + pos = pci_find_next_ext_capability(pdev, pos, PCI_EXT_CAP_ID_DVSEC); Overly long lines again. > +static void cxl_mem_remove(struct pci_dev *pdev) > +{ > +} No need for the empty remove callback. > +MODULE_AUTHOR("Intel Corporation"); A module author is not a company.