From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7923C63699 for ; Sat, 14 Nov 2020 00:49:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8435022263 for ; Sat, 14 Nov 2020 00:49:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MqdPjOPO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726143AbgKNAt0 (ORCPT ); Fri, 13 Nov 2020 19:49:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45364 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgKNAtZ (ORCPT ); Fri, 13 Nov 2020 19:49:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605314964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Pgbto6s6aJWzu/I6GVSYjwAc7k98Nrj4vzE4Tm0+xE=; b=MqdPjOPOU08qh/5AeNZZD80BhRJhRRMv1j1N1TRgv+zccd2RWQg15A4kfTtoAXuG16pWoC GS4ZQRssuCpoIjI5VfC0xOSCpO4hSz7vobIeUInt1WZHY5cuzTjxombhZ5Nv+MZm8iFRZO aEk3kRBwGsaRSmoC7P+6zjlShb3U+QE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-cJKt-FEhN_unyUcxBk_KIQ-1; Fri, 13 Nov 2020 19:49:20 -0500 X-MC-Unique: cJKt-FEhN_unyUcxBk_KIQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E6AEE5F9D1; Sat, 14 Nov 2020 00:49:17 +0000 (UTC) Received: from treble (ovpn-117-69.rdu2.redhat.com [10.10.117.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0594A60C15; Sat, 14 Nov 2020 00:49:13 +0000 (UTC) Date: Fri, 13 Nov 2020 18:49:11 -0600 From: Josh Poimboeuf To: Sami Tolvanen Cc: Peter Zijlstra , Jann Horn , the arch/x86 maintainers , Masahiro Yamada , Steven Rostedt , Will Deacon , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arch , Linux ARM , linux-kbuild , kernel list , linux-pci@vger.kernel.org Subject: Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps Message-ID: <20201114004911.aip52eimk6c2uxd4@treble> References: <20201023173617.GA3021099@google.com> <20201110022924.tekltjo25wtrao7z@treble> <20201110174606.mp5m33lgqksks4mt@treble> <20201113195408.atbpjizijnhuinzy@treble> <20201113223412.inono2ekrs7ky7rm@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Nov 13, 2020 at 03:31:34PM -0800, Sami Tolvanen wrote: > > #else /* !CONFIG_STACK_VALIDATION */ > > @@ -123,6 +129,8 @@ struct unwind_hint { > > .macro UNWIND_HINT sp_reg:req sp_offset=0 type:req end=0 > > .endm > > #endif > > +.macro STACK_FRAME_NON_STANDARD func:req > > +.endm > > This macro needs to be before the #endif, so it's defined only for > assembly code. This breaks my arm64 builds even though x86 curiously > worked just fine. Yeah, I noticed that after syncing objtool.h with the tools copy. Fixed now. I've got fixes for some of the other warnings, but I'll queue them up and post when they're all ready. -- Josh