From: Mark Brown <broonie@kernel.org>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: linux-pci@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
bcm-kernel-feedback-list@broadcom.com,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/6] PCI: brcmstb: Add control of EP voltage regulator(s)
Date: Thu, 26 Nov 2020 11:49:12 +0000 [thread overview]
Message-ID: <20201126114912.GA8506@sirena.org.uk> (raw)
In-Reply-To: <20201125192424.14440-3-james.quinlan@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On Wed, Nov 25, 2020 at 02:24:19PM -0500, Jim Quinlan wrote:
> + for (i = 0; i < PCIE_REGULATORS_MAX; i++) {
> + ep_reg = devm_regulator_get_optional(dev, ep_regulator_names[i]);
> + if (IS_ERR(ep_reg)) {
Does PCI allow supplies to be physically absent? If not then the driver
shouldn't be using regulator_get_optional() and much of the code here
can be deleted.
> +static void brcm_set_regulators(struct brcm_pcie *pcie, bool on)
> +{
This is open coding the regulator bulk APIs.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-26 11:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 19:24 [PATCH v1 0/6] PCI: brcmstb: add EP regulators and panic handler Jim Quinlan
2020-11-25 19:24 ` [PATCH v1 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators Jim Quinlan
2020-11-25 19:24 ` [PATCH v1 2/6] PCI: brcmstb: Add control of EP voltage regulator(s) Jim Quinlan
2020-11-26 11:49 ` Mark Brown [this message]
2020-11-27 20:26 ` Jim Quinlan
2020-11-30 12:06 ` Mark Brown
2020-11-25 19:24 ` [PATCH v1 3/6] PCI: brcmstb: Do not turn off regulators if EP can wake up Jim Quinlan
2020-11-25 19:24 ` [PATCH v1 4/6] PCI: brcmstb: Give 7216 SOCs their own config type Jim Quinlan
2020-11-25 19:24 ` [PATCH v1 5/6] PCI: brcmstb: Add panic/die handler to RC driver Jim Quinlan
2020-11-25 19:24 ` [PATCH v1 6/6] PCI: brcmstb: check return value of clk_prepare_enable() Jim Quinlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126114912.GA8506@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsaenzjulienne@suse.de \
--cc=robh@kernel.org \
--subject='Re: [PATCH v1 2/6] PCI: brcmstb: Add control of EP voltage regulator(s)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).