From: Christoph Hellwig <hch@lst.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Hans de Goede <hdegoede@redhat.com>,
Greg KH <gregkh@linuxfoundation.org>,
Tom Yan <tom.ty89@gmail.com>, Christoph Hellwig <hch@lst.de>,
linux-usb <linux-usb@vger.kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH 2/2] usb-storage: revert from scsi_add_host_with_dma() to scsi_add_host()
Date: Mon, 30 Nov 2020 18:24:01 +0100 [thread overview]
Message-ID: <20201130172401.GA1735@lst.de> (raw)
In-Reply-To: <20201130172004.GA966032@rowland.harvard.edu>
On Mon, Nov 30, 2020 at 12:20:04PM -0500, Alan Stern wrote:
> > https://lore.kernel.org/linux-usb/fde7e11f-5dfc-8348-c134-a21cb1116285@redhat.com/T/#t
>
> It's hard to go wrong with reverting, so it's okay with me.
>
> Still, Hans, have you checked out the difference between the
> scsi_add_host() and scsi_add_host_with_dma() calls? It's just a matter
> of using dev vs. sysdev. In particular, have you checked to see what
> those two devices are on your system?
>
> It seems likely that if one of those calls messes up some DMA settings,
> the other one does too -- just maybe not settings that matter much.
The effects from scsi_add_host_with_dma should be:
(1) picking which device is used for the SCSI dma map helpers
(2) use dma_max_mapping_size() to limite the I/O size
The helpers affected by (1) are not used by UAS (or usb-storage for that
matter), while we do have a real bug in the intel-iommu with bounce
buffering implementation used in the bug report. So my clear bet is on
(2) not limiting the size, but the patch that would have fixed this
did not make a different for Hans, which leaves me a little confused.
next prev parent reply other threads:[~2020-11-30 17:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 11:36 5.10 regression, many XHCI swiotlb buffer is full / DMAR: Device bounce map failed errors on thunderbolt connected XHCI controller Hans de Goede
2020-11-18 21:43 ` Hans de Goede
2020-11-23 14:49 ` Hans de Goede
2020-11-24 10:27 ` Christoph Hellwig
2020-11-24 10:31 ` Hans de Goede
2020-11-24 12:17 ` Mathias Nyman
2020-11-27 11:41 ` Hans de Goede
2020-11-27 12:32 ` 5.10 regression caused by: "uas: fix sdev->host->dma_dev": " Hans de Goede
2020-11-27 16:19 ` Christoph Hellwig
2020-11-27 18:12 ` Hans de Goede
2020-11-28 1:25 ` Tom Yan
2020-11-28 10:43 ` Hans de Goede
2020-11-28 15:48 ` [PATCH 1/2] uas: revert from scsi_add_host_with_dma() to scsi_add_host() Tom Yan
2020-11-28 15:48 ` [PATCH 2/2] usb-storage: " Tom Yan
2020-11-30 9:50 ` Hans de Goede
2020-11-30 12:58 ` Tom Yan
2020-11-30 13:23 ` Hans de Goede
2020-11-30 13:30 ` Greg KH
2020-11-30 13:36 ` Hans de Goede
2020-11-30 13:53 ` Greg KH
2020-11-30 13:55 ` Hans de Goede
2020-12-04 15:02 ` Greg KH
2020-11-30 17:20 ` Alan Stern
2020-11-30 17:24 ` Christoph Hellwig [this message]
2020-11-30 18:18 ` Hans de Goede
2020-11-30 18:57 ` Tom Yan
2020-11-30 19:01 ` Tom Yan
2020-11-30 20:36 ` Alan Stern
2020-11-30 14:39 ` Tom Yan
2020-11-30 9:48 ` [PATCH 1/2] uas: " Hans de Goede
2020-11-30 19:30 ` Tom Yan
2020-12-01 11:09 ` Hans de Goede
2020-11-28 17:15 ` 5.10 regression caused by: "uas: fix sdev->host->dma_dev": many XHCI swiotlb buffer is full / DMAR: Device bounce map failed errors on thunderbolt connected XHCI controller Christoph Hellwig
2020-11-30 8:43 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130172401.GA1735@lst.de \
--to=hch@lst.de \
--cc=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).