From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E475EC19425 for ; Wed, 9 Dec 2020 09:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80DE923B75 for ; Wed, 9 Dec 2020 09:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728723AbgLIJEM (ORCPT ); Wed, 9 Dec 2020 04:04:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:40154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728634AbgLIJDx (ORCPT ); Wed, 9 Dec 2020 04:03:53 -0500 Date: Wed, 9 Dec 2020 14:33:00 +0530 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607504585; bh=Y8sKKGrlYezUfpA9QSrlmnL0kO7yXjvMcIxMPszDLQU=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=ZYv88C+wY/E/J2SeDl906oq3dpbKDT6luvBWvgQIoTtv6uk70LSXQOc4LV4/Ckte2 t2UovonfT5iDGd4TYZiJMKtE6Td0rbMVabgQIfxxzGAPJPouzmrrf7Cdq5VSoEWG56 q3+OKUTzYzW22kRBiuIhOsQUhVtGj0btEIGytZTd6kpR81vO0k3bNJzFp7kxiFMuAS P2jivjBpreQyW8DQ9NQIzE3uS8JtbsnUyXVSE1qVpB3csHKn7duH6xd5l8cNGL9/dL p0AYMZhW78mhf8JJeZgcCWjjWmJu/y/PpwrMg7iVUj5PLUcBVq4nuWF8fIxyWO+fHP iGoo++aTYv9fg== From: Vinod Koul To: Heiner Kallweit Cc: Bjorn Helgaas , Jonathan Corbet , Jens Axboe , Viresh Kumar , Andy Shevchenko , Dan Williams , David Miller , Lee Jones , Ion Badulescu , Jakub Kicinski , Lino Sanfilippo , Christian Lamparter , Kalle Valo , Luis Chamberlain , Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , James Smart , Dick Kennedy , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Greg Kroah-Hartman , Jiri Slaby , Peter Chen , Felipe Balbi , "linux-pci@vger.kernel.org" , linux-doc@vger.kernel.org, Linux Kernel Mailing List , linux-ide@vger.kernel.org, dmaengine@vger.kernel.org, "netdev@vger.kernel.org" , linux-parisc@vger.kernel.org, linux-wireless , SCSI development list , linux-serial@vger.kernel.org, Linux USB Mailing List Subject: Re: [PATCH] PCI: Remove pci_try_set_mwi Message-ID: <20201209090300.GI8403@vkoul-mobl> References: <4d535d35-6c8c-2bd8-812b-2b53194ce0ec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d535d35-6c8c-2bd8-812b-2b53194ce0ec@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 09-12-20, 09:31, Heiner Kallweit wrote: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of > pci_set_mwi() have a comment that it's an optional feature. I don't > think there's much sense in this separation and the use of > __must_check. Therefore remove pci_try_set_mwi() and remove the > __must_check attribute from pci_set_mwi(). > I don't expect either function to be used in new code anyway. > > Signed-off-by: Heiner Kallweit > --- > patch applies on top of pci/misc for v5.11 > --- > drivers/dma/dw/pci.c | 2 +- > drivers/dma/hsu/pci.c | 2 +- Acked-By: Vinod Koul -- ~Vinod